Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option in config flow to add virtual power sensor to group on creation #992

Merged
merged 6 commits into from
Aug 13, 2022
Merged

Option in config flow to add virtual power sensor to group on creation #992

merged 6 commits into from
Aug 13, 2022

Conversation

bramstroker
Copy link
Owner

@bramstroker bramstroker commented Aug 13, 2022 •
edited
Loading

Todo

  • Removal of config entry must also remove from group

@bramstroker bramstroker marked this pull request as draft August 13, 2022 08:53
@bramstroker bramstroker mentioned this pull request Aug 13, 2022
Closed
@coveralls
Copy link

coveralls commented Aug 13, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2852304602

  • 34 of 34 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 93.238%
Totals Coverage Status
Change from base Build 2851150151: 0.07%
Covered Lines: 2275
Relevant Lines: 2440
💛 - Coveralls

@bramstroker bramstroker marked this pull request as ready for review August 13, 2022 11:55
@sonarcloud
Copy link

sonarcloud bot commented Aug 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bramstroker bramstroker merged commit 2e59cca into master Aug 13, 2022
@bramstroker bramstroker deleted the feat/dynamic_add_group branch August 21, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
config-flow enhancement New feature or request group
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bramstroker @coveralls