Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IOverride cache #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bsless
Copy link

@bsless bsless commented Mar 19, 2024

Speeds up :long benchmark ~2.5x and :mixed ~2x

Closes #87

src/fipp/visit.cljc Outdated Show resolved Hide resolved
src/fipp/edn.cljc Outdated Show resolved Hide resolved
src/fipp/edn.cljc Outdated Show resolved Hide resolved
src/fipp/edn.cljc Outdated Show resolved Hide resolved
@brandonbloom
Copy link
Owner

Thanks for the PR and making the changes! Hopefully I'll have a chance to follow-up / validate next weekend.

@bsless
Copy link
Author

bsless commented Mar 25, 2024

Alright, applied all requested changes and fixes (including missed typo)

@bsless
Copy link
Author

bsless commented Apr 8, 2024

Gentle bump :)

@brandonbloom
Copy link
Owner

I haven't forgotten about you. I only really get to work on OSS on weekends, and not every weekend. Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fipp.ednize/override? uses satisfies?
2 participants