Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign and verify #1195

Closed
wants to merge 10 commits into from
Closed

Sign and verify #1195

wants to merge 10 commits into from

Conversation

v-kat
Copy link
Contributor

@v-kat v-kat commented Feb 5, 2022

Summary

Sign and verify still needs security review of the go-ethereum library and testing.

Type of change ( select one )

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

@v-kat v-kat requested a review from husobee February 5, 2022 00:55
utils/httpsignature/ecdsa.go Outdated Show resolved Hide resolved
@v-kat v-kat marked this pull request as ready for review February 10, 2022 20:49
utils/httpsignature/personalsign.go Outdated Show resolved Hide resolved
utils/httpsignature/personalsign.go Outdated Show resolved Hide resolved
@@ -9,8 +9,9 @@ require (
github.com/alecthomas/jsonschema v0.0.0-20200530073317-71f438968921
github.com/alicebob/miniredis/v2 v2.18.0
github.com/asaskevich/govalidator v0.0.0-20200108200545-475eaeb16496
github.com/btcsuite/btcutil v0.0.0-20190316010144-3ac1210f4b38
github.com/btcsuite/btcutil v0.0.0-20190425235716-9e5f4b9a998d

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few days ago the github.com/btcsuite/btcutil library was moved under btcutil directory of the btcd repository. I'd use the new dependency path github.com/btcsuite/btcd/btcutil here instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to address this but haven't done anything with go modules in years. It's likely I broke something a592867

@v-kat v-kat changed the title Draft for sign and verify Sign and verify Mar 7, 2022
@v-kat v-kat closed this Mar 11, 2022
@pavelbrm pavelbrm deleted the ECDSA-sign-verify branch December 19, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants