-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign and verify #1195
Closed
Closed
Sign and verify #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-kat
commented
Feb 10, 2022
suggested changes for personal sign on http signature verify
v-kat
commented
Feb 10, 2022
gpestana
suggested changes
Feb 11, 2022
@@ -9,8 +9,9 @@ require ( | |||
github.com/alecthomas/jsonschema v0.0.0-20200530073317-71f438968921 | |||
github.com/alicebob/miniredis/v2 v2.18.0 | |||
github.com/asaskevich/govalidator v0.0.0-20200108200545-475eaeb16496 | |||
github.com/btcsuite/btcutil v0.0.0-20190316010144-3ac1210f4b38 | |||
github.com/btcsuite/btcutil v0.0.0-20190425235716-9e5f4b9a998d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to address this but haven't done anything with go modules in years. It's likely I broke something a592867
evq
reviewed
Feb 14, 2022
evq
reviewed
Feb 14, 2022
v-kat
commented
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sign and verify still needs security review of the go-ethereum library and testing.
Type of change ( select one )