Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pay with bat skus #1789

Merged
merged 29 commits into from
Aug 18, 2023
Merged

Pay with bat skus #1789

merged 29 commits into from
Aug 18, 2023

Conversation

husobee
Copy link
Contributor

@husobee husobee commented Mar 13, 2023

Summary

Type of change ( select one )

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before submitting this PR:

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security / privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan:

@husobee husobee self-assigned this Mar 13, 2023
@husobee husobee marked this pull request as draft March 27, 2023 11:55
@husobee husobee changed the title WIP: Pay with bat skus Pay with bat skus Apr 24, 2023
@husobee husobee marked this pull request as ready for review April 24, 2023 15:55
@husobee husobee requested a review from pavelbrm July 12, 2023 15:43
Copy link

@mariel222 mariel222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Just some comments from the API changes to the new managed payments API.

services/skus/model/model.go Outdated Show resolved Hide resolved
services/skus/model/model.go Outdated Show resolved Hide resolved
libs/clients/radom/client.go Outdated Show resolved Hide resolved
services/skus/model/model.go Outdated Show resolved Hide resolved
@pavelbrm pavelbrm mentioned this pull request Jul 14, 2023
Copy link
Contributor

@pavelbrm pavelbrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments on the sku files, plus expressed my feedback in #1892.

libs/clients/radom/radom.go Outdated Show resolved Hide resolved
Copy link
Contributor

@pavelbrm pavelbrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. 👍

services/skus/model/model.go Outdated Show resolved Hide resolved
@husobee
Copy link
Contributor Author

husobee commented Aug 1, 2023

services/skus/controllers.go Show resolved Hide resolved
libs/clients/radom/radom.go Show resolved Hide resolved
Copy link
Contributor

@pavelbrm pavelbrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge. Somehow, the recent conflict resolution brought in back code that has been removed. We need to fix that.

cc @husobee

fixing test
@husobee
Copy link
Contributor Author

husobee commented Aug 18, 2023

Please do not merge. Somehow, the recent conflict resolution brought in back code that has been removed. We need to fix that.

cc @husobee

@pavelbrm I have corrected the merge faults. Please take a look when you can?

@pavelbrm
Copy link
Contributor

Please do not merge. Somehow, the recent conflict resolution brought in back code that has been removed. We need to fix that.
cc @husobee

@pavelbrm I have corrected the merge faults. Please take a look when you can?

Thanks @husobee ! I have deleted the code that had to be deleted (some of the fixes have brought in the old implementation of payment methods). Also, addressed some of my comments on gateway management (moved that to the client).

As soon as I see tests pass, will re-approve the PR.

@husobee husobee merged commit 7e66a53 into master Aug 18, 2023
9 checks passed
@husobee husobee deleted the pay-with-bat-skus branch August 18, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants