Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

production 2023-03-24_1 #1798

Merged
merged 2 commits into from
Mar 27, 2023
Merged

production 2023-03-24_1 #1798

merged 2 commits into from
Mar 27, 2023

Conversation

husobee
Copy link
Contributor

@husobee husobee commented Mar 24, 2023

Summary

Type of change ( select one )

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before submitting this PR:

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security / privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan:

clD11 and others added 2 commits March 20, 2023 15:07
* filter out creds past order expiry from being inserted

updated based on review feedback

check error state

check if we do not have an expiresat on the order

make sure expires at is set in tests on order creation

* static set test valid for

* set order to paid after creation in test
@husobee husobee self-assigned this Mar 24, 2023
@husobee husobee merged commit 01b2309 into prod Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants