Sugarcoat resources #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShivanKaul
commented
Jan 3, 2022
| @@ -1,8 +1,26 @@ | |||
| [ | |||
| { | |||
| "name": "brave-fix", | |||
| "aliases": ["bf"], | |||
There was a problem hiding this comment.
Do we need this alias?
antonok-edm
previously approved these changes
Jan 3, 2022
There was a problem hiding this comment.
Looks good to me but let's confirm with @ryanbr about the bf alias before merging
|
Yeah we still need "bf" @ShivanKaul |
ShivanKaul
force-pushed
the
local-sugarcoat-resources
branch
from
ffb6368
to
6b395e0
Compare
ShivanKaul
force-pushed
the
local-sugarcoat-resources
branch
from
6b395e0
to
cf84b96
Compare
|
@ryanbr gotcha, added that back in. It would be nice if we could generate the alias automatically; I don't want to retrofit an alias for every sugarcoat resource just because of brave-fix though, so leaving it as a manual change, added a note to |
antonok-edm
previously approved these changes
Jan 5, 2022
ShivanKaul
force-pushed
the
local-sugarcoat-resources
branch
from
0867ddf
to
d072009
Compare
antonok-edm
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.