Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Crowdin updates #1197

Merged
merged 1 commit into from
Jul 19, 2024
Merged

New Crowdin updates #1197

merged 1 commit into from
Jul 19, 2024

Conversation

brave-support-admin
Copy link
Contributor

No description provided.

Copy link

[puLL-Merge] - brave/ads-ui@1197

Description

This PR makes several changes to the GraphQL schema, updates some translations, and modifies some component imports. The main changes appear to be related to campaign states, billing types, and registration denials.

Changes

Changes

  1. src/graphql-client/graphql.ts:

    • Deprecated the 'CPSV' BillingType
    • Added a new 'CampaignEffectiveState' enum
    • Modified the 'CampaignState' enum values to use lowercase
    • Updated types for various campaign-related fields
    • Added new fields for registration denials
  2. src/graphql/ads-serve.graphql.schema.json:

    • Updated schema to reflect changes in graphql.ts
  3. src/locales/en.po, es.po, pt.po:

    • Updated translations for various strings
    • Added new translations for added features
  4. src/locales/test.po:

    • Updated line numbers for some translations

Possible Issues

  • The deprecation of 'CPSV' BillingType may affect existing code that relies on this value.
  • The change in CampaignState enum values from uppercase to lowercase may require updates in code that uses these values directly.

Security Hotspots

No significant security issues are apparent in this change.

### Description
This PR updates the GraphQL schema, modifies campaign state and billing type enums, and updates translations. It also introduces new fields for registration denials and makes changes to component imports.

<details>
<summary><i>Changes</i></summary>

### Changes
1. src/graphql-client/graphql.ts:
   - Deprecated 'CPSV' BillingType
   - Added 'CampaignEffectiveState' enum
   - Modified 'CampaignState' enum to use lowercase values
   - Updated types for campaign-related fields
   - Added fields for registration denials

2. src/graphql/ads-serve.graphql.schema.json:
   - Updated to reflect changes in graphql.ts

3. src/locales/en.po, es.po, pt.po:
   - Updated and added translations

4. src/locales/test.po:
   - Updated line numbers for some translations

</details>

### Possible Issues
- Deprecation of 'CPSV' BillingType may affect existing code
- Change in CampaignState enum values may require code updates

@IanKrieger IanKrieger merged commit 0d5cac7 into master Jul 19, 2024
8 checks passed
@IanKrieger IanKrieger deleted the crowdin_master branch July 19, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants