Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove registration choice, add search page #1199

Merged
merged 4 commits into from
May 23, 2024

Conversation

IanKrieger
Copy link
Member

@IanKrieger IanKrieger commented May 23, 2024

Add a more verbose distinction as to what users are signing up for when it comes to search.


Screenshare.-.2024-05-23.8_39_12.AM.mp4

@IanKrieger IanKrieger requested a review from a team as a code owner May 23, 2024 12:27
Copy link

[puLL-Merge] - brave/ads-ui@1199

Description

This PR adds a new Search Landing Page to the Brave Ads UI. It includes information about Brave Search Ads, a button to determine eligibility, and an image carousel showcasing search results. The landing page aims to tap into the large volume of annual web searches and promote Brave Search Ads to potential advertisers.

Changes

Changes

  • src/App.tsx

    • Added import and route for the new SearchLandingPage component
    • Changed the /search route to render SearchLandingPage instead of redirecting to "/contact"
  • src/auth/registration/

    • Removed the AccountChoice.tsx file which contained the UI for choosing between browser ads and search ads
    • Updated Register.tsx to remove the AccountChoice route and directly redirect to "register/browser"
  • src/basic-attention-token/BasicAttentionTokenLandingPage.tsx

    • Updated the "Get started" button link to just "/register" instead of "/register?pos=personal"
  • src/components/AppBar/LandingPageAppBar.tsx

    • Added "Brave Search" link to header
    • Refactored to use a mobile menu for links on small screens
    • Minor style and sizing tweaks
  • src/search/SearchLandingPage.tsx (new)

    • New component that renders the Search landing page
    • Includes headlines, description, CTA button, and image carousel
    • Uses SearchTalkingPoints component to render key selling points
  • src/search/SearchTalkingPoints.tsx (new)

    • New component that renders the key value propositions of Brave Search Ads
    • Promotes Search Ads as incremental reach, as effective as Google, and risk-free to test

Security Hotspots

None identified. The changes are primarily adding new UI components and routes without handling any sensitive user data or system operations that could introduce vulnerabilities.

@IanKrieger IanKrieger merged commit ce0414a into master May 23, 2024
8 checks passed
@IanKrieger IanKrieger deleted the feat/remove-search-distinction branch May 23, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants