Ignore unmaintained warning for twoway #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't release-blocking; there are no known issues, we just can't expect upstream response if one is reported. So ignore for now to reduce lint noise. This should be removed when we're no longer shipping builds using the dependency, probably via brave/brave-core#17037
diracdeltas
approved these changes
Feb 13, 2023
|
@diracdeltas please go ahead and merge if this is ready as-is. I don't have write access. |
|
Merge ping? |
|
@rillian please close brave/brave-browser#28228 if it's not going to be addressed in any other way (otherwise please assign and link a pr) |
The real fix is the linked brave/brave-core#17037 for 1.50 and later. |
|
As I noted in brave/brave-browser#28228 (comment), this will be rolled in with brave/brave-core#17368 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't release-blocking; there are no known issues, we just can't expect upstream response if one is reported. So ignore for now to reduce lint noise.
This should be removed when we're no longer shipping builds using the dependency, probably via brave/brave-core#17037