Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending state in the UI for Uphold #10023

Closed
NejcZdovc opened this issue May 31, 2020 · 2 comments · Fixed by brave/brave-core#6140
Closed

Add pending state in the UI for Uphold #10023

NejcZdovc opened this issue May 31, 2020 · 2 comments · Fixed by brave/brave-core#6140

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented May 31, 2020

We should be adding pending state into wallet button so user can disconnect from there if they are stuck

@NejcZdovc NejcZdovc added this to Icebox in Rewards May 31, 2020
@NejcZdovc NejcZdovc added this to Backlog in Brave Rewards via automation Jul 14, 2020
@NejcZdovc NejcZdovc removed this from Icebox in Rewards Jul 14, 2020
@NejcZdovc NejcZdovc self-assigned this Jul 16, 2020
@NejcZdovc NejcZdovc moved this from Backlog to In progress in Brave Rewards Jul 21, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Jul 21, 2020
@NejcZdovc NejcZdovc moved this from In progress to Review in Brave Rewards Jul 21, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Jul 21, 2020
Brave Rewards automation moved this from Review to Done Jul 21, 2020
@NejcZdovc NejcZdovc added this to the 1.13.x - Nightly milestone Jul 21, 2020
@NejcZdovc NejcZdovc moved this from Done to Waiting Uplift in Brave Rewards Jul 27, 2020
@LaurenWags
Copy link
Member

Marking as QA/Blocked as this needs a new 1.12.x build to test

@btlechowski
Copy link

btlechowski commented Aug 6, 2020

Verification passed on

Brave 1.12.107 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6140

  • Verified pending popup on brave://rewards
    image

  • Verified pending popup on Rewards Panel
    image

Also verified in Polish locale. Pending is not translated. Logged #11100
image


Verification passed on


Brave | 1.12.107 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)

  • Verified test plan from Adds pending status for uphold brave-core#6140

  • Confirmed that the Pending popup is shown when clicking on "Verify Wallet"
    image

  • Brave rewards settings page
    image

  • Confirmed if you then go add personal information as required for Uphold (name, phone number etc) but do not verify your email, you will still get the Pending popup when clicking on "Verify Wallet":
    image

  • Brave rewards settings page
    image

  • Confirmed if you then verify your email as required, you will now get the "Connected" popup:
    image
    image


Verified passed with

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified brave/brave-core#6140 (comment)

Screen Shot 2020-08-07 at 3 30 20 PM

Screen Shot 2020-08-07 at 3 30 31 PM

  • Confirmed if you then go add personal information as required for Uphold (name, phone number etc) but do not verify your email, you will still get the Pending popup when clicking on "Verify Wallet":

Screen Shot 2020-08-07 at 3 39 34 PM

Screen Shot 2020-08-07 at 3 39 48 PM

  • Confirmed if you then verify your email as required, you will now get the "Connected" popup:

Screen Shot 2020-08-07 at 3 40 54 PM

Screen Shot 2020-08-07 at 3 41 07 PM

@rebron rebron changed the title Add pending state in the UI for uphold Add pending state in the UI for Uphold Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment