Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create card if pending status #6252

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Do not create card if pending status #6252

merged 1 commit into from
Jul 30, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jul 29, 2020

Resolves brave/brave-browser#10995

Submitter Checklist:

Test Plan:

  • Clean profile, staging, enable Rewards, claim grant
  • Click on Verify wallet
  • Create a new account (email, password, etc)
  • You're momentarily taken to brave://rewards and then directed back to uphold
  • Go to brave://rewards, click on Verify Wallet
  • Make sure that you see a pending popup

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.14.x - Nightly milestone Jul 29, 2020
@NejcZdovc NejcZdovc requested a review from a team July 29, 2020 18:17
@NejcZdovc NejcZdovc self-assigned this Jul 29, 2020
@NejcZdovc NejcZdovc requested review from emerick and zenparsing and removed request for a team July 29, 2020 18:17
ledger_->SaveExternalWallet(ledger::kWalletUphold, wallet_ptr->Clone());

if (wallet_ptr->address.empty()) {
if (wallet_ptr->status != ledger::WalletStatus::PENDING &&
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should only create card when people are out of pending state

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit dd8ef45 into master Jul 30, 2020
@NejcZdovc NejcZdovc deleted the card-pending branch July 30, 2020 05:14
brave-builds pushed a commit that referenced this pull request Jul 30, 2020
@LaurenWags
Copy link
Member

Verified passed with

Brave | 1.14.6 Chromium: 84.0.4147.105 (Official Build) nightly (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified test plan from description
  • Confirmed pending popup on brave://rewards and panel

Screen Shot 2020-07-31 at 7 27 36 AM

Screen Shot 2020-07-31 at 7 28 08 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Verify Wallet drop down not displayed when in Pending state - follow up to 10023
4 participants