Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Payment server url handling #11284

Closed
NejcZdovc opened this issue Aug 18, 2020 · 1 comment · Fixed by brave/brave-core#6479
Closed

[Desktop] Payment server url handling #11284

NejcZdovc opened this issue Aug 18, 2020 · 1 comment · Fixed by brave/brave-core#6479
Assignees
@NejcZdovc
Labels
dev-concern feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Brave Rewards
Milestone
1.15.x - Release #1

Comments

@NejcZdovc
Copy link
Contributor

Ref: #10987
@NejcZdovc NejcZdovc added this to Backlog in Brave Rewards via automation Aug 18, 2020
@NejcZdovc NejcZdovc mentioned this issue Aug 18, 2020
Closed
6 tasks
@NejcZdovc NejcZdovc self-assigned this Aug 18, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 20, 2020
@NejcZdovc
Adds payment server handler
241c47f 
Resolves brave/brave-browser#11284
@NejcZdovc NejcZdovc moved this from Backlog to In progress in Brave Rewards Aug 21, 2020
@NejcZdovc NejcZdovc added this to the 1.15.x - Nightly milestone Aug 24, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 24, 2020
@NejcZdovc
Adds payment server handler
b728d35 
Resolves brave/brave-browser#11284
@NejcZdovc NejcZdovc mentioned this issue Aug 24, 2020
Merged
32 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 24, 2020
@NejcZdovc
Adds payment server handler
57464ad 
Resolves brave/brave-browser#11284
@NejcZdovc NejcZdovc moved this from In progress to Review in Brave Rewards Aug 24, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 25, 2020
@NejcZdovc
Adds payment server handler
9ced6de 
Resolves brave/brave-browser#11284
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 26, 2020
@NejcZdovc
Adds payment server handler
0ca64d3 
Resolves brave/brave-browser#11284
Brave Rewards automation moved this from Review to Done Aug 26, 2020
This was referenced Sep 22, 2020
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Sep 22, 2020 •
edited by GeetaSarvadnya

Verified passed with

Brave	1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
Revision	ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS	macOS Version 10.14.6 (Build 18G3020)

Verified test plan from brave/brave-core#6479

Using VG (UGP grant on staging), confirmed able to do 1 time tips, recurring tips, and AC VG1 VG2 VG3 VG4 VG5
Confirmed brave://rewards-internals showed data from above VG contributions (1 time tips, recurring tips, AC) as expected VG6
Using restored anon deposited wallet (staging env), confirmed able to do 1 time tips, recurring tips, and AC anon1 anon2 anon3 anon4 anon5
Confirmed brave://rewards-internals showed data from above anon wallet contributions (1 time tips, recurring tips, AC) as expected anon6
Using KYC'd Uphold wallet (staging env), confirmed able to do 1 time tips, recurring tips, and AC Uphold1 Uphold2 Uphold3 Uphold4 Uphold5
Confirmed brave://rewards-internals showed data from above Uphold contributions (1 time tips, recurring tips, AC) as expected Uphold6

Verification passed on


Brave | 1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

Verified test plan from brave/brave-core#6479

Using VG (UGP grant on staging), confirmed able to do 1 time tips, recurring tips, and AC

image
image
image
image
image

Confirmed brave://rewards-internals showed data from above VG contributions (1 time tips, recurring tips, AC) as expected

image
image
image
image

Using restored anon deposited wallet (staging env), confirmed able to do 1 time tips, recurring tips, and AC

image
image
image
image
image

Confirmed brave://rewards-internals showed data from above anon wallet contributions (1 time tips, recurring tips, AC) as expected

image
image

Using KYC'd Uphold wallet (staging env), confirmed able to do 1 time tips, recurring tips, and AC

image
image
image
image
image

Confirmed brave://rewards-internals showed data from above Uphold contributions (1 time tips, recurring tips, AC) as expected

image
image

Verification passed on

Brave 1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6479

Using VG (UGP grant on staging), confirmed able to do 1 time tips, recurring tips, and AC

image
image
image
image

Confirmed brave://rewards-internals showed data from above VG contributions (1 time tips, recurring tips, AC) as expected

image
image

Using restored anon deposited wallet (staging env), confirmed able to do 1 time tips, recurring tips, and AC

image
image
image
image

Confirmed brave://rewards-internals showed data from above anon wallet contributions (1 time tips, recurring tips, AC) as expected

image

Using KYC'd Uphold wallet (staging env), confirmed able to do 1 time tips, recurring tips, and AC

image
image
image
image

Confirmed brave://rewards-internals showed data from above Uphold contributions (1 time tips, recurring tips, AC) as expected

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
dev-concern feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Brave Rewards
  
Done
Milestone
1.15.x - Release #1
Development

Successfully merging a pull request may close this issue.

Adds payment server handler brave/brave-core
4 participants
@NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya