-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds payment server handler #6479
Conversation
b728d35
to
57464ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ads changes LGTM
vendor/bat-native-ledger/src/bat/ledger/internal/contribution/contribution_anon_card.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/credentials/credentials_sku.cc
Outdated
Show resolved
Hide resolved
components/brave_rewards/browser/test/common/rewards_browsertest_response.cc
Show resolved
Hide resolved
57464ad
to
7eac605
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of nits up to you if they're worth addressing.
vendor/bat-native-ledger/src/bat/ledger/internal/endpoint/payment/payment_server.cc
Outdated
Show resolved
Hide resolved
...edger/src/bat/ledger/internal/endpoint/payment/post_credentials/post_credentials_unittest.cc
Outdated
Show resolved
Hide resolved
...bat/ledger/internal/endpoint/payment/post_transaction_anon/post_transaction_anon_unittest.cc
Outdated
Show resolved
Hide resolved
...ledger/internal/endpoint/payment/post_transaction_uphold/post_transaction_uphold_unittest.cc
Outdated
Show resolved
Hide resolved
...bat-native-ledger/src/bat/ledger/internal/endpoint/payment/post_votes/post_votes_unittest.cc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
return ledger::Result::LEDGER_ERROR; | ||
} | ||
|
||
if (status_code != net::HTTP_CREATED) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking: can this endpoint ever return 200 for any reason? Do we want to treat 200 as an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, only 201 is success
vendor/bat-native-ledger/src/bat/ledger/internal/endpoint/payment/payment_server.h
Outdated
Show resolved
Hide resolved
7eac605
to
5dd6bb7
Compare
Resolves brave/brave-browser#11284
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
check that following is working
Reviewer Checklist:
After-merge Checklist:
changes has landed on.