Adds payment server handler #6479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
requested review from
a team,
emerick and
zenparsing
and removed request for
a team
NejcZdovc
force-pushed
the
payment-server
branch
from
b728d35
to
57464ad
Compare
emerick
reviewed
Aug 24, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/contribution/contribution_anon_card.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/credentials/credentials_sku.cc
Outdated
Show resolved
Hide resolved
components/brave_rewards/browser/test/common/rewards_browsertest_response.cc
Show resolved
Hide resolved
NejcZdovc
force-pushed
the
payment-server
branch
from
57464ad
to
7eac605
Compare
emerick
approved these changes
Aug 25, 2020
vendor/bat-native-ledger/src/bat/ledger/internal/endpoint/payment/payment_server.cc
Outdated
Show resolved
Hide resolved
...edger/src/bat/ledger/internal/endpoint/payment/post_credentials/post_credentials_unittest.cc
Outdated
Show resolved
Hide resolved
...bat/ledger/internal/endpoint/payment/post_transaction_anon/post_transaction_anon_unittest.cc
Outdated
Show resolved
Hide resolved
...ledger/internal/endpoint/payment/post_transaction_uphold/post_transaction_uphold_unittest.cc
Outdated
Show resolved
Hide resolved
...bat-native-ledger/src/bat/ledger/internal/endpoint/payment/post_votes/post_votes_unittest.cc
Outdated
Show resolved
Hide resolved
zenparsing
approved these changes
Aug 25, 2020
| return ledger::Result::LEDGER_ERROR; | ||
| } | ||
|
|
||
| if (status_code != net::HTTP_CREATED) { |
There was a problem hiding this comment.
Just checking: can this endpoint ever return 200 for any reason? Do we want to treat 200 as an error?
There was a problem hiding this comment.
yes, only 201 is success
vendor/bat-native-ledger/src/bat/ledger/internal/endpoint/payment/payment_server.h
Outdated
Show resolved
Hide resolved
NejcZdovc
force-pushed
the
payment-server
branch
from
7eac605
to
5dd6bb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#11284
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
check that following is working
Reviewer Checklist:
After-merge Checklist:
changes has landed on.