Update the Default Browser Modal

[anthonypkeane]

Description

Please update the Default Browser call out on Android as per the design below.

Designs

Toast message: Select Brave Browser and tap ‘Always’

Assets

Figma: https://www.figma.com/file/atoL4LN2kd8ILnPGwohUoV/?node-id=1369%3A18913

[deeppandya]

@AlexeyBarabash i will start looking into this issue. if you haven't started working on it.

[deeppandya]

@karenkliu @jamesmudgett UI in 2nd and 3rd are handled by the android system and the UI depends on android OS on the device.

[karenkliu]

@deeppandya I thought we were able to at least tweak the text a little though?

[deeppandya]

@karenkliu to keep the consistent, it doesn't allow to change anything on the dialog. i can try with custom UI but i think we should go with default android UI.

[deeppandya]

@karenkliu i am updating logic to show the modal based on below,
New user - 2nd launch, then after 5 days
Existing user - next app launch, then after 5 days

[deeppandya]

one quick question : should we still keep the existing Toast and notification we have on android for default browser ?

[karenkliu]

☝️ Yes

[deeppandya]

Logic update :
User would keep seeing the p3a modal until he/she clicks on continue and when user taps on continue, we set to show the default browser modal on the next app open. So It has no relation to app open count directly. And when user sees the first default browser modal, we set the 5 day timer and when we try to show the default browser modal again on day 5, we check if user has already set brave as default or not.

[srirambv]

Verification passed on OnePlus 6T running 1.20.98 x64 build

• Verified steps from Update the Default Browser Modal #12390 (comment)
• Verified on a clean install default browser modal is shown on the second launch
• Verified the second prompt is shown after 5 days if not set as default
• Verified no prompt is shown on 10th day
• Verified upgrading from GPS version first shows P3A opt-in message
• Verified on upgrade, the second launch shows the default browser modal
• Verified the second prompt is shown after 5 days if not set as default
• Verified selecting Set as default browser from the menu doesn't bring up the default browser modal. Just shows the browser list to select

Dark Theme	Light Theme	Browser selection

---

Verification passed on Samsung Tab A running 1.20.98 x64 build

• Verified steps from Update the Default Browser Modal #12390 (comment)
• Verified on a clean install default browser modal is shown on the second launch
• Verified the second prompt is shown after 5 days if not set as default
• Verified no prompt is shown on 10th day
• Verified upgrading from GPS version first shows P3A opt-in message
• Verified on upgrade, the second launch shows the default browser modal
• Verified the second prompt is shown after 5 days if not set as default
• Verified selecting Set as default browser from the menu doesn't bring up the default browser modal. Just shows the browser list to select

Dark Theme	Light Theme	Browser selection

---

Logged follow-up issue(#13958) for missing translations

[karenkliu]

@anthonypkeane The layout for set Brave as default on Android tablets looks a bit funky; is it worth fixing in a followup?

[deeppandya]

@karenkliu @anthonypkeane i think we should start having spec for tablet if the UI is important for tablet users. because we mainly focus on phone UI so some changes would look weird for huge screens and for tablet UI, we would have to explicitly make changes in UI for tablet version. So if we different spec for both, it would be ideal.