Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add set default browser modal (Uplift to 1.20.x) #7756

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Add set default browser modal (Uplift to 1.20.x) #7756

merged 1 commit into from
Feb 2, 2021

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Feb 1, 2021 •
edited by kjozwiak
Loading

Uplift of #7745
Resolves brave/brave-browser#12390

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya
Add set default browser modal
7bd0827 
Update behaviour for p3a modal
@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 1, 2021
@deeppandya deeppandya added this to the 1.20.x - Beta milestone Feb 1, 2021
@deeppandya deeppandya requested a review from a team February 1, 2021 04:46
@deeppandya deeppandya self-assigned this Feb 1, 2021
kjozwiak
kjozwiak approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.20.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #7745 (comment).

@kjozwiak kjozwiak merged commit df9cb48 into 1.20.x Feb 2, 2021
@kjozwiak kjozwiak deleted the add_set_default_browser_modal_android_1.20.x branch February 2, 2021 15:58
@bsclifton
Copy link
Member

Because translations aren't available (see brave/brave-browser#13958), we should revert this and land with 1.21

bsclifton added a commit that referenced this pull request Feb 4, 2021
@bsclifton
Revert "Merge pull request #7756 from brave/add_set_default_browser_m…
6914769 
…odal_android_1.20.x"

This reverts commit df9cb48, reversing
changes made to 2343348.
@bsclifton bsclifton mentioned this pull request Feb 4, 2021
Merged
@bsclifton
Copy link
Member

Moved to 1.21 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.21.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@deeppandya @bsclifton @kjozwiak