Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos and Spelling Mistakes in Rewards #1332

Closed
jonathansampson opened this issue Sep 27, 2018 · 2 comments · Fixed by brave/brave-core#535
Closed

Typos and Spelling Mistakes in Rewards #1332

jonathansampson opened this issue Sep 27, 2018 · 2 comments · Fixed by brave/brave-core#535

Comments

@jonathansampson
Copy link
Contributor

Description

The Brave Rewards deposit screen contains a few typos and spelling mistakes.

Steps to Reproduce

  1. Navigate to chrome://rewards
  2. Click Add Funds

Actual result:

Note the following mistakes:

  • Ethereum is spelled Etherium
  • Token is lowercase in Basic Attention token
  • LiteCoin is rendered with a space between Lite and Coin

Expected result:

Tokens and Coins are properly represented.

Brave version (chrome://version info)

0.55.10

Additional Information

https://github.com/search?q=org%3Abrave+Etherium&type=Code

Reported on Twitter.

@srirambv
Copy link
Contributor

Also brave/brave-core#502 (review)

@srirambv srirambv added the needs-text-change This change requires some careful wording. label Sep 28, 2018
@NejcZdovc NejcZdovc added this to the 1.0 (0.56.x) milestone Sep 28, 2018
@bbondy bbondy added this to Rewards in 1.0 Tasks by Category Sep 29, 2018
@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned davidtemkin Oct 1, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.0 (0.56.x), Releasable builds 0.55.x Oct 1, 2018
@NejcZdovc NejcZdovc removed this from Rewards in 1.0 Tasks by Category Oct 1, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 1, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 1, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 1, 2018
@btlechowski
Copy link

btlechowski commented Oct 9, 2018

Verification passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows 7

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux

Verified passed with

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

screen shot 2018-10-11 at 5 19 29 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants