Wrong time on New Tab Page

[damagicalcat]

Test plan

(taken from https://bugs.chromium.org/p/chromium/issues/detail?id=1168528#c48 and modified)

Change windows time zone to some time zone where can exists summer timer time, for instance, (America/Santiago).

1. Open a tab and then open the developer tools
2. In the console paste in the following and hit enter:
   Intl.DateTimeFormat().resolvedOptions().timeZone
   • In Chrome 88 it shows: America/Santiago

Disable Automatic change DST option on Windows (America/Santiago).

1. Open a tab and then open the developer tools
2. In the console paste in the following and hit enter:
   Intl.DateTimeFormat().resolvedOptions().timeZone
   • In Chromium 88 WITHOUT the fix it shows: Etc/GMT-4
   • In Chromium 88 WITH the fix it should show Etc/GMT+4

Description

Time of brave is different from current time

Steps to Reproduce

it just happens, i did nothing to reproduce it

Actual result:

as you can see, the time on brave is different from my system time

Expected result:

both times to be the same

Brave version (info found on brave://version)

Brave	1.19.86 Chromium: 88.0.4324.96 (Official Build) (64-bit)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	Windows 10 OS Version 2004 (Build 19041.746)
JavaScript	V8 8.8.278.14
User Agent	Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.96 Safari/537.36

[bsclifton]

Related #7951

[bsclifton]

@damagicalcat has this always been a problem? (ex: are you an existing Brave user and this used to work?)

Wondering if this is a long-standing issue (ex: as seen in #7951) or if this is a new bug because of Chromium 88 which was included in our 1.19 version update

[GeetaSarvadnya]

Unable to reproduce the issue in Clean/Upgraded profile in Windows 10 x64. @damagicalcat Could you provide the STR to reproduce the issue?

Clean profile: 1.19.86

Upgraded profile: 1.18.78 to 1.19.86

[bsclifton]

What time zone are you in @damagicalcat?

@GeetaSarvadnya I wonder if there's a difference if you switch between auto / 12 hour / 24 hour

UPDATE: it's possible this is an upstream bug; @mkarolin found this:
https://bugs.chromium.org/p/chromium/issues/detail?id=1168528

[damagicalcat]

I am in pst/pdt

[tetranucleotido]

I have the same issue, I don't know if i could modify that clock.

[bsclifton]

Per user Delhills on https://community.brave.com/t/my-brave-is-showing-the-wrong-time/197973/15 a work-around seems to be:

To everyone having this problem. I changed my windows timezone to some random one and then again my actual timezone and it fixed this error. Try it.

[bsclifton]

Upstream fix coming to trunk; will likely be hotfixed into Chromium update for 88 / 89

[damagicalcat]

changing my windows time didn't work

Also, my brave's browser time is in GMT.

[bsclifton]

This should be fixed with #13915 and brave/brave-core#7795 having been merged 😄

I'm not sure there are steps we can follow to reproduce - but the fix was upstream in Chromium (see https://bugs.chromium.org/p/chromium/issues/detail?id=1168528 for more info). I'll mark as QA/No for now

[bsclifton]

Actually - found a test plan we can use; updated original post and marked as QA/Yes 😄 Ran through the steps and they work great 😄

[GeetaSarvadnya]

Verification passed on

Brave | 1.19.90 Chromium: 88.0.4324.146 (Official Build) (64-bit)
-- | --
Revision | 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS | Windows 10 OS Version 2004 (Build 19041.746)

Verified the test plan from the description

• Reproduced the issue in 1.19.86 Chromium: 88.0.4324.96

NTP clock is different from system time

Upgraded profile to 1.19.90 Chromium: 88.0.4324.146 and ensured Time in NTP is displayed same as system time

12- hours clock

24 - hour clock

---

Verified passed with

Brave	1.19.90 Chromium: 88.0.4324.146 (Official Build) (64-bit)
Revision	406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS	Windows 10 OS Version 1909 (Build 18363.1256)

Using 1.19.88 Chromium: 88.0.4324.96, confirmed time works correctly when "Adjust for daylight saving time automatically" is enabled:

Using 1.19.88 Chromium: 88.0.4324.96, reproduced the issue when "Adjust for daylight saving time automatically" is not enabled:

Example	Example

Using 1.19.90 Chromium: 88.0.4324.146, confirmed time works correctly when "Adjust for daylight saving time automatically" is enabled:

Using 1.19.90 Chromium: 88.0.4324.146, confirmed time works correctly when "Adjust for daylight saving time automatically" is not enabled:

Example	Example

---

Verified passed with

Brave	1.19.90 Chromium: 88.0.4324.146 (Official Build) (32-bit)
Revision	406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS	Windows 10 OS Version 2009 (Build 19042.685)

Using 1.19.88 Chromium: 88.0.4324.96, confirmed time works correctly when "Adjust for daylight saving time automatically" is enabled:

Using 1.19.88 Chromium: 88.0.4324.96, reproduced the issue when "Adjust for daylight saving time automatically" is not enabled:

Example	Example

Using 1.19.90 Chromium: 88.0.4324.146, confirmed time works correctly when "Adjust for daylight saving time automatically" is enabled:

Using 1.19.90 Chromium: 88.0.4324.146, confirmed time works correctly when "Adjust for daylight saving time automatically" is not enabled:

Example	Example