Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple RPill from Brave Ads #13889

Closed
tmancey opened this issue Feb 2, 2021 · 3 comments · Fixed by brave/brave-core#7954
Closed

Decouple RPill from Brave Ads #13889

tmancey opened this issue Feb 2, 2021 · 3 comments · Fixed by brave/brave-core#7954
Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
Ads
Milestone
1.22.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Feb 2, 2021

Decouple RPill to allow requirements outside of Brave Ads to check for RPill or BPill
@tmancey tmancey added enhancement priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/ads OS/Desktop labels Feb 2, 2021
@tmancey tmancey added this to New issues in Ads via automation Feb 2, 2021
@tmancey tmancey moved this from New issues to Backlog in Ads Feb 2, 2021
@tmancey tmancey moved this from Backlog to In progress in Ads Feb 12, 2021
@tmancey tmancey mentioned this issue Feb 12, 2021
Merged
23 tasks
@tmancey tmancey moved this from In progress to Review in Ads Feb 12, 2021
Ads automation moved this from Review to Done Feb 14, 2021
@tmancey tmancey added this to the 1.22.x - Nightly milestone Feb 14, 2021
@btlechowski
Copy link

QA/Blocked asked @tmancey re RPill and BPill

@btlechowski
Copy link

btlechowski commented Mar 6, 2021 •
edited by kjozwiak

Verification passed on

Brave 1.22.53 Chromium: 89.0.4389.72 (Official Build) beta (64-bit)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS Ubuntu 18.04 LTS

Verified in https://github.com/brave/internal/issues/751#issuecomment-791909642

Verification passed on


Brave | 1.22.56 Chromium: 89.0.4389.72 (Official Build) dev (64-bit)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | Windows 10 OS Version 2004 (Build 19041.867)

Verified in https://github.com/brave/internal/issues/751#issuecomment-791909642

Verification PASSED on macOS 11.2.3 via the following build:

Brave | 1.22.66 Chromium: 89.0.4389.90 (Official Build) (x86_64)
--- | ---
Revision | 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS | macOS Version 11.2.3 (Build 20D91)

Verified via https://github.com/brave/internal/issues/751#issuecomment-775734983.

@btlechowski
Copy link

Added QA/Test-All-Platforms. Seems to be related to #14232.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
Ads
  
Done
Milestone
1.22.x - Release
Development

Successfully merging a pull request may close this issue.

Decouple RPill from Brave Ads brave/brave-core
5 participants
@tmancey @kjozwiak @LaurenWags @btlechowski @GeetaSarvadnya