Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Processor Arch into stats ping #14232

Closed
keur opened this issue Feb 18, 2021 · 3 comments · Fixed by brave/brave-core#7993
Closed

Integrate Processor Arch into stats ping #14232

keur opened this issue Feb 18, 2021 · 3 comments · Fixed by brave/brave-core#7993

Comments

@keur
Copy link
Contributor

keur commented Feb 18, 2021

Have brave_stats send processor architecture and make use of the API exposed in brave/brave-core#7954 if ads are enabled.

@keur keur added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude OS/Desktop labels Feb 18, 2021
@keur keur self-assigned this Feb 18, 2021
keur pushed a commit to brave/brave-core that referenced this issue Feb 18, 2021
keur pushed a commit to brave/brave-core that referenced this issue Feb 18, 2021
keur pushed a commit to brave/brave-core that referenced this issue Feb 18, 2021
keur pushed a commit to brave/brave-core that referenced this issue Feb 18, 2021
@keur keur changed the title Integrate IsUncertainFuture into stats ping Integrate Processor Arch into stats ping Feb 18, 2021
@keur keur added this to the 1.22.x - Nightly milestone Feb 18, 2021
@btlechowski
Copy link

Added QA/Test-All-Platforms different platforms may have different ways of obtaining arch.

@stephendonner
Copy link

stephendonner commented Mar 3, 2021

Verified FIXED using

Brave 1.22.51 Chromium: 89.0.4389.72 (Official Build) beta (x86_64)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS macOS Version 11.2.2 (Build 20D80)
  1. clean profile, launched Brave
  2. enabled Ads via Start using Rewards button
  3. let time (48 hours) elapse
  4. launched Charles Proxy
  5. re-launched Brave
  6. examined network traffic from https://laptop-updates.brave.com

Verified that &arch=X86_64 is appended to the usage ping here: https://laptop-updates.brave.com/1/usage/brave-core?platform=osx-bc&channel=beta&version=1.22.51&daily=true&weekly=false&monthly=false&first=false&woi=2021-03-01&dtoi=2021-03-03&ref=BRV001&adsEnabled=true&arch=x86_64

Screen Shot 2021-03-05 at 12 36 25 PM


Verification passed on

Brave 1.22.53 Chromium: 89.0.4389.72 (Official Build) beta (64-bit)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS Ubuntu 18.04 LTS

Clean profile:
image
After 48h
image

Rest of the testing done in https://github.com/brave/internal/issues/755#issuecomment-790923797


Verification passed on


Brave | 1.22.56 Chromium: 89.0.4389.72 (Official Build) dev (64-bit)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | Windows 10 OS Version 2004 (Build 19041.804)


Clean profile:

image

After 48h
image

Additional testing is covered in brave/internal#755 (comment)

@kjozwiak
Copy link
Member

kjozwiak commented Mar 4, 2021

@brave/legacy_qa there's additional STR/Cases that we'll need to run through via https://github.com/brave/internal/issues/755. Please add the verifications for those cases inside https://github.com/brave/internal/issues/755 similar to what we did with https://github.com/brave/internal/issues/751#issuecomment-775734983 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants