New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple RPill from Brave Ads #7954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
force-pushed
the
issues/13889
branch
from
February 12, 2021 18:42
30a6137
to
8751ff4
Compare
bridiver
reviewed
Feb 12, 2021
tmancey
force-pushed
the
issues/13889
branch
from
February 12, 2021 18:52
8751ff4
to
e02af49
Compare
tmancey
force-pushed
the
issues/13889
branch
2 times, most recently
from
February 12, 2021 18:56
9be6a5d
to
3e9f13d
Compare
kylehickinson
approved these changes
Feb 12, 2021
bridiver
approved these changes
Feb 12, 2021
tmancey
force-pushed
the
issues/13889
branch
from
February 12, 2021 22:10
3e9f13d
to
1c84148
Compare
keur
reviewed
Feb 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
tmancey
force-pushed
the
issues/13889
branch
2 times, most recently
from
February 13, 2021 07:45
c03938c
to
6bb610e
Compare
tmancey
force-pushed
the
issues/13889
branch
from
February 13, 2021 07:47
6bb610e
to
4ee2b7c
Compare
gpestana
approved these changes
Feb 13, 2021
keur
approved these changes
Feb 13, 2021
moritzhaller
approved these changes
Feb 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#13889
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Confirm RPill detection is working as expected when refilling unblinded tokens