Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple RPill from Brave Ads #7954

Merged
merged 1 commit into from Feb 14, 2021
Merged

Decouple RPill from Brave Ads #7954

merged 1 commit into from Feb 14, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Feb 12, 2021

Resolves brave/brave-browser#13889

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Confirm RPill detection is working as expected when refilling unblinded tokens

Copy link
Contributor

@keur keur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

components/brave_ads/browser/ads_service_impl.cc Outdated Show resolved Hide resolved
components/rpill/common/rpill.cc Outdated Show resolved Hide resolved
components/rpill/common/rpill.cc Outdated Show resolved Hide resolved
components/rpill/common/rpill.cc Outdated Show resolved Hide resolved
components/rpill/common/rpill.cc Outdated Show resolved Hide resolved
@tmancey tmancey force-pushed the issues/13889 branch 2 times, most recently from c03938c to 6bb610e Compare February 13, 2021 07:45
Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@tmancey tmancey merged commit e44fbd7 into master Feb 14, 2021
@tmancey tmancey deleted the issues/13889 branch February 14, 2021 14:15
@tmancey tmancey added this to the 1.22.x - Nightly milestone Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants