Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing index_files directory of IPFS-imported page times out #15907

Closed
Tracked by #17112
stephendonner opened this issue May 17, 2021 · 2 comments · Fixed by brave/brave-core#8980
Closed
Tracked by #17112

Importing index_files directory of IPFS-imported page times out #15907

stephendonner opened this issue May 17, 2021 · 2 comments · Fixed by brave/brave-core#8980

Comments

@stephendonner
Copy link

Description

Importing index_files directory of IPFS-imported page times out

(This is edge case, I know, but wanted to get it logged, all the same.)

Steps to Reproduce

  1. new profile
  2. load ipns://brantly.eth
  3. choose Use a local node on the interstitial page
  4. load https://www.wikipedia.org
  5. context-click page and choose Import to IPFS -> This page
  6. load brave://ipfs-internals
  7. click on My Node
  8. click on Files and then the brave-imports directory
  9. navigate through to the index_files directory
  10. now, context-click the page and choose Import to IPFS -> This page again
  11. wait a long time

Actual result:

After some time, we get a 504 Gateway Time-out

Screen Shot 2021-05-17 at 2 25 05 PM

Expected result:

Not sure what should happen, exactly, as this is pretty edge-case. But it should either work, or fail sooner, I'd think

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.25.60 Chromium: 90.0.4430.212 (Official Build) beta (x86_64)
Revision e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS macOS Version 11.3.1 (Build 20E241)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes
@stephendonner stephendonner added this to Untriaged in IPFS via automation May 17, 2021
@spylogsster spylogsster moved this from Untriaged to In Review in IPFS Jun 1, 2021
IPFS automation moved this from In Review to Done Jun 2, 2021
@spylogsster spylogsster self-assigned this Jun 2, 2021
@spylogsster
Copy link

blocked imports form api origins

@spylogsster spylogsster added this to the 1.27.x - Nightly milestone Jun 2, 2021
@stephendonner
Copy link
Author

Verified FIXED using the testplans, both inline, here, and from brave/brave-core#8980, with build

Brave 1.27.37 Chromium: 91.0.4472.77 (Official Build) nightly (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.5 (Build 20G5023d)

Steps:

  1. new profile
  2. load ipns://brantly.eth
  3. choose Use a local node on the interstitial page
  4. load https://www.wikipedia.org
  5. context-click page and choose Import to IPFS -> This page`
  6. load brave://ipfs-internals
  7. click on My Node
  8. click on Files and then the brave-imports directory
  9. navigate through to the index_files directory
  10. context-clicked the page and confirmed the Import to IPFS -> This page option isn't present any longer

Screen Shot 2021-06-02 at 7 50 00 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
IPFS
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants