Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension verification options not matching Chromium on Linux #15024

Closed
bsclifton opened this issue Mar 30, 2021 · 4 comments · Fixed by brave/brave-core#8392
Closed

Extension verification options not matching Chromium on Linux #15024

bsclifton opened this issue Mar 30, 2021 · 4 comments · Fixed by brave/brave-core#8392

Comments

@bsclifton
Copy link
Member

bsclifton commented Mar 30, 2021

Test plan

See brave/brave-core#8392

Description

Creating based on conversations / troubleshooting which took place in #2457

Basically, problem involves installing an extension which is signed but not in Chrome Web Store.

  • Installing this component is not possible on macOS / Windows in Chromium. We properly match that behavior 👍
  • However, Chromium on Linux WILL allow you to install. We are not allowing ☹️ Therefore not matching Chromium

Steps to Reproduce

Actual result:

We don't match Chromium behavior

Expected result:

We should match Chromium behavior

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.24.32 Chromium: 90.0.4430.41 (Official Build) nightly (64-bit)
Revision e9c92b1eaca8487e212f3f6bc081fdb6d4863759-refs/branch-heads/4430@{#723}
OS Windows 10 OS Version 2009 (Build 19042.867)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Y
  • Can you reproduce this issue with the beta channel? Y
  • Can you reproduce this issue with the nightly channel? Y

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N
  • Does the issue resolve itself when disabling Brave Rewards? N
  • Is the issue reproducible on the latest version of Chrome? N
@bsclifton bsclifton self-assigned this Mar 30, 2021
bsclifton added a commit to brave/brave-core that referenced this issue Mar 30, 2021
bsclifton added a commit to brave/brave-core that referenced this issue Mar 31, 2021
bsclifton added a commit to brave/brave-core that referenced this issue Apr 6, 2021
bsclifton added a commit to brave/brave-core that referenced this issue Apr 6, 2021
bsclifton added a commit to brave/brave-core that referenced this issue Apr 6, 2021
bsclifton added a commit to brave/brave-core that referenced this issue Apr 6, 2021
@bsclifton bsclifton added this to the 1.25.x - Nightly milestone Apr 7, 2021
@bsclifton
Copy link
Member Author

Originally reported by folks in #5761 - apologies for not finding that (and creating this new issue). You can view lots of reports of the problem there from folks

@btlechowski
Copy link

The test plan from brave/brave-core#8392 involves all platforms. Added QA/Test-All-Platforms label.

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 17, 2021
@stephendonner
Copy link

stephendonner commented May 17, 2021

Verified PASSED using slightly modified steps (checked with @bsclifton) from brave/brave-core#8392 on

Brave 1.25.60 Chromium: 90.0.4430.212 (Official Build) beta (x86_64)
Revision e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS macOS Version 11.3.1 (Build 20E241)

Steps:

  1. New profile (macOS or Windows); launch Brave
  2. Downloaded chromium-cleaner
  3. Visited brave://extensions
  4. Dragged the chromium-cleaner.crx extension from desktop onto the chrome://extensions page
  5. Verified extension shows in brave://extensions as disabled (shows warning; you can't enable).
  6. Repeated steps 4-6 while toggled in Developer mode; confirmed same (disabled) result
regular brave://extensions Developer mode brave://extensions
Screen Shot 2021-05-17 at 12 34 23 PM Screen Shot 2021-05-17 at 12 32 43 PM

Verification passed on

Brave | 1.25.60 Chromium: 90.0.4430.212 (Official Build) beta (64-bit)
-- | --
Revision | e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS | Windows 10 OS Version 2004 (Build 19041.985)

Regular brave://extensions Enable developer mode brave://extensions
image image

Verification passed on

Brave 1.25.60 Chromium: 90.0.4430.212 (Official Build) beta (64-bit)
Revision e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS Ubuntu 18.04 LTS

I was unable to install the extension when developer mode was off. Logged #15956
image

Installed the extension when developer mode was on:

image image

@LaurenWags
Copy link
Member

Changing release-notes/include to release-notes/exclude since Linux still does not work as expected and a follow up issue is logged (Unable to install self-signed extension when developer mode is off on Linux #15956).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment