Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable FLoC in Brave #14942

Closed
pes10k opened this issue Mar 25, 2021 · 8 comments · Fixed by brave/brave-core#8468
Closed

Disable FLoC in Brave #14942

pes10k opened this issue Mar 25, 2021 · 8 comments · Fixed by brave/brave-core#8468
Assignees
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy/chromium-redqueen Work to remove privacy-harming "features" added in Chromium. privacy QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@pes10k
Copy link
Contributor

pes10k commented Mar 25, 2021

Currently Brave disables the FLoC component. However there is other FLoC functionality shipped in Chromium (behind origin trials). We should disable FLoC completely in Brave, including:

  1. FLoC client-side determinations of cohorts
  2. Any reporting of FLoC cohort determinations to Google (or otherwise) servers (i.e., the reporting used for k-anonymity cohort protections)
  3. FLoC JS methods (i.e. document.interestCohort)
  4. Any UI related to the FloC permission (i.e., interest-cohort)
@pes10k pes10k added privacy OS/Android Fixes related to Android browser functionality privacy/chromium-redqueen Work to remove privacy-harming "features" added in Chromium. OS/Desktop labels Mar 25, 2021
@pes10k pes10k assigned mkarolin and unassigned mkarolin Mar 25, 2021
@pes10k pes10k added this to Backlog in Android General via automation Mar 25, 2021
@iefremov iefremov self-assigned this Mar 29, 2021
@iefremov
Copy link
Contributor

iefremov commented Apr 7, 2021

@pes10k
can you please provide more details on "Any UI related to the FloC permission (i.e., interest-cohort)" - I haven't spotted any related UIs

@pes10k
Copy link
Contributor Author

pes10k commented Apr 7, 2021

Sounds good, if there is no UI, then happy for that part to be a NOOP.

The explainer doc just says there is there will be a new permission, and so the request was to disable any UI (for example, any content setting control) related to that permission. But if that doesn't exist, then, even easier!

Android General automation moved this from Backlog to Done/Closed Apr 8, 2021
mariospr added a commit to brave/brave-core that referenced this issue Apr 9, 2021
We have to do it this way now that kFlocIdSortingLshBasedComputation
feature flag has been removed from upstream and got unconditionally
enabled all the time.

Related:
* brave/brave-browser#14942
* https://www.chromestatus.com/feature/5710139774468096
* https://chromium.googlesource.com/chromium/src.git/+/master/components/federated_learning/

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d

commit 77462226d2aa2980c80e009ab7de098407af653d
Author: Yao Xiao <yaoxia@chromium.org>
Date:   Wed Mar 31 23:11:46 2021 +0000

    [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests.

    Bug: 1190992
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 9, 2021
@rebron rebron added this to Completed in General Apr 9, 2021
@kjozwiak kjozwiak added this to the 1.25.x - Nightly milestone Apr 9, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Apr 9, 2021

Adding this into the 1.25.x as it landed via brave/brave-core#8468.

@ElijahLynn
Copy link

For those wondering what FLoC is like I was:

@stephendonner
Copy link
Collaborator

stephendonner commented Apr 12, 2021

Verified FIXED using nightly build

Brave 1.25.11 Chromium: 90.0.4430.61 (Official Build) nightly (x86_64)
Revision dced74d4124b26b14126b611853d33512b60c7b6-refs/branch-heads/4430@{#1115}
OS macOS Version 11.2.3 (Build 20D91)

Using the steps from brave/brave-core#8468:

  1. went to brave://components and ensured there's no Federated Learning of Cohorts component

Screen Shot 2021-04-12 at 4 09 04 PM

2. opened the devtools console, typed `document.interestCohort()` and confirmed that I got an error:

Screen Shot 2021-04-12 at 4 07 15 PM


Verification passed on

Brave 1.25.59 Chromium: 90.0.4430.212 (Official Build) beta (64-bit)
Revision e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#8468

  1. went to brave://components and ensured there's no Federated Learning of Cohorts component
    image

  2. opened the devtools console, typed document.interestCohort() and confirmed that I got an error:
    image


Verification passed on


Brave | 1.25.60 Chromium: 90.0.4430.212&nbsp;(Official Build)&nbsp;beta&nbsp;(64-bit)
-- | --
Revision | e3cd97fc771b893b7fd1879196d1215b622c2bed-refs/branch-heads/4430@{#1429}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

  1. went to brave://components and ensured there's no Federated Learning of Cohorts component
    image

  2. opened the devtools console, typed document.interestCohort() and confirmed that I got an error:
    image

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.25.51 x64 Beta build


Verification passed on Samsung Tab A with Android 10 running 1.25.51 x64 Beta build

image

@dentistformyeye
Copy link

A yellow warning shows up in the browser console when I go to https://web.archive.org/. I'm not sure whether this means there's still something that could be removed or whether this message is supposed to appear.
Error with Permissions-Policy header: Unrecognized feature: 'interest-cohort'.
If it doesn't appear at first, refreshing the page might make it show up.

On a page archived on the Wayback Machine such as this, the yellow warning can show up twice.

I'm on Brave version 1.25.68 (Chromium: 91.0.4472.77).

@pes10k
Copy link
Contributor Author

pes10k commented Jun 1, 2021

Hi @dentistformyeye , thanks for the comment, but what you're seeing isn't a bug, its as intended.

Brave removes all FLoC support in the browser. This also removes support for understanding the "disable FLoC" header, which is why you're seeing the message you're seeing in the console. Or, put differently, since Brave doesn't support FLoC, it also doesn't support the "disable FLoC" command. So, you can safely disregard this message, knowing that FLoC isn't enabled.

Hope that helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy/chromium-redqueen Work to remove privacy-harming "features" added in Chromium. privacy QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Android General
  
Done/Closed
Development

Successfully merging a pull request may close this issue.