Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search API changes #15323

Closed
bbondy opened this issue Apr 15, 2021 · 0 comments · Fixed by brave/brave-core#8537
Closed

Search API changes #15323

bbondy opened this issue Apr 15, 2021 · 0 comments · Fixed by brave/brave-core#8537
Assignees
@bbondy
Labels
feature/search OS/Desktop QA/No release-notes/exclude
Milestone
1.23.x - Release #2

Comments

@bbondy
Copy link
Member

bbondy commented Apr 15, 2021

  • Only append lang and country params when there is a value
  • Add search-dev-local.brave.com so it's easier to do testing via a hosts file
  • Add filter_explicit_results param which is only specified when true is returned
  • Add a unitest for the different ways to generate the URLs
  • Update the browsertest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
feature/search OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.23.x - Release #2
Development

Successfully merging a pull request may close this issue.

Brave search param changes and extra tests brave/brave-core
3 participants
@bbondy @kjozwiak @SergeyZhukovsky