Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup search API (Uplift to 1.23.x Release #2) #8553

Merged
merged 15 commits into from Apr 18, 2021
Merged

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Apr 16, 2021

Fixes:

Uplift of:

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bbondy bbondy added this to the 1.23.x - Release #2 milestone Apr 16, 2021
@bbondy bbondy requested a review from a team April 16, 2021 15:34
@bbondy bbondy requested a review from bridiver as a code owner April 16, 2021 15:34
@bbondy bbondy self-assigned this Apr 16, 2021
@bbondy bbondy changed the title Search sw 1.23.x Backup search API (Uplift to 1.23.x) Apr 16, 2021
@bbondy bbondy changed the title Backup search API (Uplift to 1.23.x) Backup search API (Uplift to 1.23.x Release #2) Apr 16, 2021
@kjozwiak
Copy link
Member

post-init failed due to a audit-dep warning as per https://ci.brave.com/job/pr-brave-browser-search-sw-1.23.x-post-init/1/execution/node/145/log/. However, this is a known issue and not related to this specific PR.

Going to restart both macOS & Linux just in case as there were some test-browser failures that I haven't seen before. Specifically the Gemini. Most likely unrelated though.

@kjozwiak
Copy link
Member

test-browser failed on Linux as per https://ci.brave.com/job/pr-brave-browser-search-sw-1.23.x-linux/2/execution/node/244/log/ & https://ci.brave.com/job/pr-brave-browser-search-sw-1.23.x-linux/2/execution/node/247/log/. However, these are known issues and unrelated to this specific PR.

02:51:54  5 tests crashed:
02:51:54      BraveStatsUpdaterBrowserTest.StatsUpdaterMigration (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:275)
02:51:54      BraveStatsUpdaterBrowserTest.StatsUpdaterSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:154)
02:51:54      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithDefaultReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:229)
02:51:54      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:327)
02:51:54      BraveStatsUpdaterBrowserTest.StatsUpdaterThresholdSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:191)

@kjozwiak
Copy link
Member

macOS failed the last time but we should be good as the original test failures that I saw via https://ci.brave.com/job/pr-brave-browser-search-sw-1.23.x-macos/1/execution/node/242/log/ & https://ci.brave.com/job/pr-brave-browser-search-sw-1.23.x-macos/1/execution/node/245/log/ didn't happen the second time around via https://ci.brave.com/job/pr-brave-browser-search-sw-1.23.x-macos/2/execution/node/245/log/ & https://ci.brave.com/job/pr-brave-browser-search-sw-1.23.x-macos/2/execution/node/248/log/. The ones that failed the second time around I've seen before so they're definitely intermittent and unrelated to this specific PR.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.23.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 9d7a663 into 1.23.x Apr 18, 2021
@kjozwiak kjozwiak deleted the search-sw-1.23.x branch April 18, 2021 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants