New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave search param changes and extra tests #8537
Conversation
post-init CI failed due to unrelated audit problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please either make the change now to use the test http server to handle the response or in a follow-up, but it is very important that we do not mock the response this way for browser tests
ed0df59
to
85b19b6
Compare
85b19b6
to
21f37ea
Compare
cd8604f
to
e27f396
Compare
new commits lgtm |
post-init failed due to unrelated audit errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failures are unrelated. Reached out to @emerick and @zenparsing
macOS has 2 tests failures. I discussed it with @tmancey and it seems like it's a known problem related to rewards everywhere and not related to that PR
|
Brave search param changes and extra tests
Fix for console warning about leo.nft size.
Resolves brave/brave-browser#15295
Resolves brave/brave-browser#15323
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: