Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave search param changes and extra tests #8537

Merged
merged 5 commits into from Apr 16, 2021
Merged

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Apr 14, 2021

Resolves brave/brave-browser#15295
Resolves brave/brave-browser#15323

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@SergeyZhukovsky
Copy link
Member Author

post-init CI failed due to unrelated audit problem

Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please either make the change now to use the test http server to handle the response or in a follow-up, but it is very important that we do not mock the response this way for browser tests

@bbondy bbondy changed the title Brave search tests Brave search param changes and extra tests Apr 15, 2021
@SergeyZhukovsky
Copy link
Member Author

new commits lgtm

@SergeyZhukovsky
Copy link
Member Author

post-init failed due to unrelated audit errors

Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are unrelated. Reached out to @emerick and @zenparsing

@SergeyZhukovsky
Copy link
Member Author

macOS has 2 tests failures. I discussed it with @tmancey and it seems like it's a known problem related to rewards everywhere and not related to that PR

22:13:36  2 tests crashed:
22:13:36      BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion071WithRewardsAndAdsEnabled_ForSupportedLocale_ForUnsupportedLocale_RewardsShouldBeEnabled_AdsShouldBeEnabled (../../brave/components/brave_ads/browser/ads_service_browsertest.cc:1004)
22:13:36      BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion12WithRewardsAndAdsEnabled_ForSupportedLocale_ForNewlySupportedLocale_RewardsShouldBeEnabled_AdsShouldBeDisabled (../../brave/components/brave_ads/browser/ads_service_browsertest.cc:1004)

@SergeyZhukovsky SergeyZhukovsky merged commit e552bcc into master Apr 16, 2021
@SergeyZhukovsky SergeyZhukovsky deleted the brave_search_tests branch April 16, 2021 13:06
bbondy pushed a commit that referenced this pull request Apr 16, 2021
Brave search param changes and extra tests
@SergeyZhukovsky SergeyZhukovsky added this to the 1.25.x - Nightly milestone Apr 16, 2021
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
Fix for console warning about leo.nft size.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants