Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Brave VPN on macOS #15810

Closed
bsclifton opened this issue May 12, 2021 · 2 comments · Fixed by brave/brave-core#9246
Closed

Implement Brave VPN on macOS #15810

bsclifton opened this issue May 12, 2021 · 2 comments · Fixed by brave/brave-core#9246
Assignees
Labels
feature/vpn feature-request OS/Desktop OS/macOS premium All issues related to Brave Premium priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@bsclifton
Copy link
Member

Description

Part of parent issue #15804

The goal here would be to create an implementation in brave-core which handles VPN on macOS. Each OS can provide an OS specific implementation for a "VPN Service".

This would need the ability to:

  • Create a VPN connection with the OS.
  • Update a connection (if details change)
  • Connect to the VPN
  • Disconnect from the VPN
  • Remove the VPN connection from the OS

We should be able to do an implementation similar to what was done on iOS. Also see files in https://github.com/brave/brave-ios/tree/development/Client/Frontend/BraveVPN (@iccub lead the implementation on iOS)

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 14, 2021
@mattmcalister mattmcalister added feature/vpn premium All issues related to Brave Premium labels May 17, 2021
@simonhong simonhong self-assigned this Jun 21, 2021
@simonhong
Copy link
Member

Add BraveVPNConnectionManager implementation with Guardian's https://github.com/brave/GuardianConnect

@simonhong simonhong added QA/No and removed QA/Yes labels Jun 21, 2021
simonhong added a commit to brave/brave-core that referenced this issue Jun 23, 2021
fix brave/brave-browser#15810

This manager is based on external GuardianConnect framework.
@simonhong
Copy link
Member

simonhong commented Jun 28, 2021

Whenever application tries to configure VPN configuration via NEVPNManager api, macOS asks to user with below popup.
Screen Shot 2021-06-28 at 4 06 01 PM

If Don't Allow is clicked, vpn configuration process can't go further.
If Allow is clicked, user have to type password again via below popup.
Screen Shot 2021-06-28 at 4 11 18 PM
After inserting proper password, vpn is connected.
This is resolved. I put wrong data as a password when inserting item into KeyChain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/vpn feature-request OS/Desktop OS/macOS premium All issues related to Brave Premium priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
4 participants