Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cid duplication for public gateways #16339

Closed
Tracked by #17112
spylogsster opened this issue Jun 10, 2021 · 1 comment · Fixed by brave/brave-core#9075
Closed
Tracked by #17112

Remove cid duplication for public gateways #16339

spylogsster opened this issue Jun 10, 2021 · 1 comment · Fixed by brave/brave-core#9075

Comments

@spylogsster
Copy link

Expected result:

  • No duplication, url opened successfully

#Test Plan

@spylogsster spylogsster changed the title Do not show badge for API urls Remove cid duplication for public gateways Jun 10, 2021
@spylogsster spylogsster self-assigned this Jun 10, 2021
@spylogsster spylogsster added this to Untriaged in IPFS via automation Jun 10, 2021
@spylogsster spylogsster moved this from Untriaged to In Progress in IPFS Jun 10, 2021
@spylogsster spylogsster moved this from In Progress to In Review in IPFS Jun 10, 2021
IPFS automation moved this from In Review to Done Jun 11, 2021
@spylogsster spylogsster added this to the 1.27.x - Nightly milestone Jun 11, 2021
@stephendonner
Copy link

Verified PASSED using the inline testplan with build

Brave 1.27.62 Chromium: 91.0.4472.101 (Official Build) nightly (x86_64)
Revision af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. loaded ipns://brantly.eth
  3. clicked on Use a local node
  4. loaded https://ipfs.io/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR
  5. clicked on the Open using IPFS badge in the URL bar
  6. confirmed I was taken to ipfs://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi/ which did not have another Open using IPFS badge
example example
Screen Shot 2021-06-14 at 11 16 17 AM Screen Shot 2021-06-14 at 11 16 20 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment