Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: "Open using IPFS" not shown on public subdomain gateways #16116

Closed
Tracked by #17112
lidel opened this issue May 27, 2021 · 1 comment · Fixed by brave/brave-core#8982
Closed
Tracked by #17112

Bug: "Open using IPFS" not shown on public subdomain gateways #16116

lidel opened this issue May 27, 2021 · 1 comment · Fixed by brave/brave-core#8982

Comments

@lidel
Copy link

lidel commented May 27, 2021

Found in nightly-1.27.25-linux-amd64:

path gateways work as expected, badge is present:

2021-05-28--01-47-14

subdomain gateways are missing the badge:

2021-05-28--01-47-31

cc @spylogsster – this might be related / fixabletogether with #16115

@stephendonner
Copy link

Verified PASSED using

Brave 1.27.56 Chromium: 91.0.4472.101 (Official Build) nightly (x86_64)
Revision af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launch Brave
  3. load ipns://brantly.eth
  4. click on Use a local node
  5. load https://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi.ipfs.dweb.link/
  6. click on the Open using IPFS badge icon in the URL bar
  7. confirm it went to ipfs://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi/
example example
Screen Shot 2021-06-10 at 3 09 24 PM Screen Shot 2021-06-10 at 3 09 28 PM

NOTE: #16339 covers the duplication seen right now on nightly where Open using IPFS keeps appearing, and I'll reverify it separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment