Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add "Show all pending contributions" view #17038

Closed
Miyayes opened this issue Jul 19, 2021 · 4 comments · Fixed by brave/brave-core#12565
Closed

[Android] Add "Show all pending contributions" view #17038

Miyayes opened this issue Jul 19, 2021 · 4 comments · Fixed by brave/brave-core#12565

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 19, 2021

Description

Add "Show all pending contributions" view on Android to match desktop.

New UI

New UI on brave://rewards settings page. When user presses "See all", it should open up into a view of all the pending tips (pending contributions list) that is responsive for Android/mobile.

Ask @Miyayes or @mkarolin for Figma.

@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality parity labels Jul 19, 2021
@Miyayes Miyayes added this to New Issues in Brave Rewards via automation Jul 19, 2021
@Miyayes Miyayes added this to Backlog in Android General via automation Jul 19, 2021
@Miyayes Miyayes assigned ghost Jul 21, 2021
@zenparsing zenparsing moved this from New Issues to Backlog (Android) in Brave Rewards Jul 28, 2021
@anthonypkeane anthonypkeane added rewards-2.0 priority/P3 The next thing for us to work on. It'll ride the trains. labels Aug 11, 2021
@anthonypkeane anthonypkeane moved this from Backlog to P3 in Android General Aug 11, 2021
@Miyayes Miyayes assigned minkyeongshin and unassigned ghost Oct 6, 2021
@Miyayes Miyayes assigned emerick and unassigned minkyeongshin and deeppandya Dec 22, 2021
@Miyayes
Copy link
Collaborator Author

Miyayes commented Dec 22, 2021

With the new Rewards redesign, the pending contributions view only appears on the brave://rewards settings page as a line item (see screenshot below). cc: @emerick

image

@emerick emerick moved this from Backlog (Android) to In progress in Brave Rewards Dec 23, 2021
@emerick emerick moved this from In progress to Backlog (Android) in Brave Rewards Jan 3, 2022
@emerick emerick moved this from Backlog (Android) to On deck in Brave Rewards Jan 26, 2022
@emerick
Copy link
Contributor

emerick commented Jan 26, 2022

@Miyayes @minkyeongshin I think we probably need to rethink this design a little bit for Android. If we want to make the smallest change possible, we could drop some columns for Android (say Type and Pending Until). Not sure if that would be enough, but it might work.

Or if we wanted to make a more comprehensive change that retained all of the data but laid things out in a more vertical format, something like:

cnn.com (Trash can icon)
  Type: One-time tip
  Pending Until: 02/01/2022
  Amount: 0.250 BAT 0.30 USD
  
yahoo.com (Trash can icon)
  Type: One-time tip
  ...

Android General automation moved this from P3 to Done/Closed Mar 14, 2022
Brave Rewards automation moved this from In progress to Done Mar 14, 2022
@mkarolin mkarolin added this to the 1.38.x - Nightly milestone Mar 14, 2022
@LaurenWags LaurenWags added QA/Test-All-Platforms QA/Test-All-Device-Types QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 7, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Apr 7, 2022

Verified on Google Pixel 3 XL with Android 12 running 1.38.83

Note - tips below were to "Unverified" creators, see linked issue below re: cross custodian and "connected" creator tipping.

  • Confirmed "Pending contributions" line item is displayed on the summary area on brave://rewards page for Android when pending tips exist
  • Confirmed when pending tips are added or removed the sum of the tips is updated correctly on brave://rewards page
  • Confirmed when pending tips are added or removed the pending tips list is updated as expected
  • Confirmed layout of pending tips list generally follows format outlined in [Android] Add "Show all pending contributions" view  #17038 (comment)
1st Pending Tip 1st Pending Tip 2nd Pending Tip 2nd Pending Tip
1 2 3 4
  • Confirmed "Pending contributions" line item is not displayed on the summary area on brave://rewards page for Android when pending tips do not exist or have been deleted
  • Confirmed pending tips can be deleted from the list
Example Example
5 6
  • Confirmed "Pending contributions" line item is not displayed on the rewards panel from URL bar whether pending tips exist or not
Rewards Panel brave://rewards page
panel settings
  • Confirmed both Monthly and One Time Tips can be shown in the "Pending Contributions" list
Example Example Example
7 8 9

Upgrade case:

  1. Installed 1.37.103 from GH releases page
  2. Enabled staging env, relaunched
  3. Enabled Rewards
  4. Claimed UGP grant
  5. Tipped a couple unverified creators to set up pending tips
  6. Confirmed no "Pending Contributions" view
  7. Closed browser
  8. Upgraded to 1.38.83 using GPS
  9. Relaunched
    ---> Confirmed able to see pending tips view on brave://rewards page
    ---> Confirmed pending tips listed were the ones set up with step 5
1.37.103 1.38.83 Pending Contributions
1 2 3

Cross custodial tipping cases and tips to "connected" creators (Brave verified but no custodial wallet) will likely be fixed when #20090 (comment) is resolved.

@LaurenWags LaurenWags added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 8, 2022
@Miyayes
Copy link
Collaborator Author

Miyayes commented Apr 20, 2022

image

Yay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Android General
  
Done/Closed
Brave Rewards
  
Done
Development

Successfully merging a pull request may close this issue.

7 participants