Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Pending Contributions" line item in Rewards summary #20819

Closed
2 tasks
Miyayes opened this issue Feb 1, 2022 · 3 comments · Fixed by brave/brave-core#12652
Closed
2 tasks

Update "Pending Contributions" line item in Rewards summary #20819

Miyayes opened this issue Feb 1, 2022 · 3 comments · Fixed by brave/brave-core#12652
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Feb 1, 2022

Description

As suggested by design team (@jenn-rhim and @minkyeongshin):

  • Update pending contributions line to be this: Pending contributions 12.00 BAT 10.00 USD. It will follow same format as other line items. The "Pending contributions" text itself will be clickable and open up the pending contributions list view.
  • Reorder the pending contributions line item to the bottom of the summary, under Monthly Tips.

Existing screenshot of UI for reference:

image

@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 1, 2022
@Miyayes Miyayes added the QA/Yes label Feb 1, 2022
@Miyayes Miyayes changed the title Move "Pending Contributions" line item in Rewards summary to bottom (under Monthly Tips) Update "Pending Contributions" line item in Rewards summary Feb 1, 2022
@Miyayes Miyayes added the polish Nice to have — usually related to front-end/visual tasks label Feb 1, 2022
@zenparsing zenparsing self-assigned this Feb 2, 2022
@zenparsing zenparsing added the priority/P4 Planned work. We expect to get to it "soon". label Feb 2, 2022
@Miyayes Miyayes assigned mkarolin and unassigned zenparsing Mar 16, 2022
@mkarolin mkarolin added this to the 1.38.x - Nightly milestone Mar 18, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 31, 2022

Verified Passed using

Brave 1.38.75 Chromium: 100.0.4896.60 (Official Build) beta (64-bit)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS Windows 11 Version 21H2 (Build 22000.593)
  • Install 1.38.75
  • Launch Brave
  • Tip unverified user (cnn.com)
  • Open brave://rewards and view Rewards Summary
  • Verified Pending contributions line is moved to last row below Monthly Tips
  • Verified the update to Pending contributions format and it is the same format as others in the summary page - Pending contributions 17.50 BAT 15.28 USD
  • Verified Pending contributions is a clickable link and it opens up the Pending contributions list view as this is existing functionality
  • Removed all Pending contributions and close the view
  • Pending contributions line is no longer displayed
ex1 ex2 ex3
Rewards summary 138x pending contributions view removed pending contributions

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 7, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Apr 7, 2022

Verified on Google Pixel 3 XL with Android 12 running 1.38.83

  • Confirmed "Pending Contributions" line item is the same as desktop / matches description
  • Confirmed when "Pending Contributions" is tapped on, it opens the list view
Example Example
1 2

Other testing for "Pending Contributions" on Android can be found under #17038 (comment).

@stephendonner
Copy link

Verified PASSED using

Brave 1.38.83 Chromium: 100.0.4896.79 (Official Build) beta (x86_64)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS macOS Version 11.6.5 (Build 20G527)

Steps:

  1. installed 1.38.83
  2. launched Brave
  3. tipped unverified user (cnn.com)
  4. opened brave://rewards and viewed Rewards Summary
  5. verified Pending contributions line is moved to last row below Monthly Tips
  6. verified the update to Pending contributions format and it is the same format as others in the summary page - Pending contributions 5.00 BAT 4.00 USD
  7. verified Pending contributions is a clickable link and it opens up the Pending contributions list view as this is existing functionality
  8. removed all Pending contributions and closed the view
  9. Pending contributions line is no longer displayed
example example example example
Screen Shot 2022-04-07 at 6 33 57 PM Screen Shot 2022-04-07 at 6 34 15 PM Screen Shot 2022-04-07 at 6 34 26 PM Screen Shot 2022-04-07 at 6 34 33 PM

@LaurenWags LaurenWags added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants