webTorrent crashing on both torrent & magnet links

[kjozwiak]

Description

WebTorrent crashing whenever attempting to download a torrent via the torrent file or the magnet link. Crashes:

• 632f0d00-eb58-d306-0000-000000000000
• 5e2f0d00-eb58-d306-0000-000000000000
• 582f0d00-eb58-d306-0000-000000000000
• 522f0d00-eb58-d306-0000-000000000000

Unfortunately, all the crash stacks appear as:

crash_reporter::DumpWithoutCrashing

Steps to Reproduce

Case #1

1. launch nightly (used 1.30.41 Chromium: 93.0.4577.51 in this case)
2. visit https://webtorrent.io/torrents/big-buck-bunny.torrent (crash)

Case #2

1. launch nightly (used 1.30.41 Chromium: 93.0.4577.51 in this case)

Visit the following:

magnet:?xt=urn:btih:209c8226b299b308beaf2b9cd3fb49212dbd13ec&dn=Tears+of+Steel&tr=udp%3A%2F%2Fexplodie.org%3A6969&tr=udp%3A%2F%2Ftracker.coppersurfer.tk%3A6969&tr=udp%3A%2F%2Ftracker.empire-js.us%3A1337&tr=udp%3A%2F%2Ftracker.leechers-paradise.org%3A6969&tr=udp%3A%2F%2Ftracker.opentrackr.org%3A1337&tr=wss%3A%2F%2Ftracker.btorrent.xyz&tr=wss%3A%2F%2Ftracker.fastcast.nz&tr=wss%3A%2F%2Ftracker.openwebtorrent.com&ws=https%3A%2F%2Fwebtorrent.io%2Ftorrents%2F&xs=https%3A%2F%2Fwebtorrent.io%2Ftorrents%2Ftears-of-steel.torrent

Actual result:

Webview crashing whenever attempting to download a torrent using WebTorrent

Expected result:

Brave shouldn't be crashing and users should be able to download torrents using WebTorrent without issues

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave | 1.30.41 Chromium: 93.0.4577.51 (Official Build) nightly (64-bit)
-- | --
Revision | 762d21050e2da59930c784c09b134d0b0b148188-refs/branch-heads/4577@{#915}
OS | Windows 10 OS Version 2009 (Build 19042.1165)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? No
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @rebron @bsclifton @mkarolin @feross @brave/legacy_qa

[stephendonner]

Verified PASSED using

Brave	1.29.74 Chromium: 93.0.4577.58 (Official Build) (x86_64)
Revision	c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS	macOS Version 11.5.2 (Build 20G95)

Case 1:

1. launch Brave
2. visited https://webtorrent.io/torrents/big-buck-bunny.torrent
3. clicked on Start Torrent
4. waited until 100% file completion

Case 2:

1. launch Brave
2. Visit the following:
   magnet:?xt=urn:btih:209c8226b299b308beaf2b9cd3fb49212dbd13ec&dn=Tears+of+Steel&tr=udp%3A%2F%2Fexplodie.org%3A6969&tr=udp%3A%2F%2Ftracker.coppersurfer.tk%3A6969&tr=udp%3A%2F%2Ftracker.empire-js.us%3A1337&tr=udp%3A%2F%2Ftracker.leechers-paradise.org%3A6969&tr=udp%3A%2F%2Ftracker.opentrackr.org%3A1337&tr=wss%3A%2F%2Ftracker.btorrent.xyz&tr=wss%3A%2F%2Ftracker.fastcast.nz&tr=wss%3A%2F%2Ftracker.openwebtorrent.com&ws=https%3A%2F%2Fwebtorrent.io%2Ftorrents%2F&xs=https%3A%2F%2Fwebtorrent.io%2Ftorrents%2Ftears-of-steel.torrent
3. clicked on Start Torrent
4. waited until 100% file completion

case 1	case 2

---

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.29.74 Chromium: 93.0.4577.58 (Official Build) (64-bit)
-- | --
Revision | c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS | Windows 10 OS Version 2009 (Build 19042.1165)

Test Case #1 - .torrent file

• ensured that clicking on Save .torrent File works without any issues
• ensured that clicking on Start Torrent correctly starts downloading the torrent/files without any issues
• ensured that stats Download %, Download speeds are being updated while the torrent is being downloaded
• ensured that Stop Torrent works without any issue and returns the user to the initial landing page
• ensured that files can be saved/opened via the SAVE FILE column
• ensured that files can be opened by clicking on them under the NAME column
• ensured that the Powered by WebTorrent opens https://webtorrent.io without any issues
• ensured Peers stat is being updated
• ensured restarting with https://webtorrent.io/torrents/big-buck-bunny.torrent as the active tab doesn't cause crashes/issues

Test Case #1 - .magnet links

• ensured that clicking on Copy Magnet Link correctly copies the link into the clipboard
• ensured that clicking on Start Torrent correctly starts downloading the torrent/files without any issues
• ensured that stats Download %, Download speeds are being updated while the torrent is being downloaded
• ensured that Stop Torrent works without any issue and returns the user to the initial landing page
• ensured that files can be saved/opened via the SAVE FILE column
• ensured that files can be opened by clicking on them under the NAME column
• ensured that the Powered by WebTorrent opens https://webtorrent.io without any issues
• ensured Peers stat is being updated
• ensured restarting with https://webtorrent.io/torrents/big-buck-bunny.torrent as the active tab doesn't cause crashes/issues

[aaaaaaaalex]

Still happening for me, just downloaded another torrent client because this one is unusable.

• Mac OS Ventura 13.2.1, M1
• Brave Version 1.49.120 Chromium: 111.0.5563.64 (Official Build) (arm64)