Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fuzzy-search to SelectAsset list #18162

Closed
onyb opened this issue Sep 16, 2021 · 0 comments · Fixed by brave/brave-core#10123
Closed

Add fuzzy-search to SelectAsset list #18162

onyb opened this issue Sep 16, 2021 · 0 comments · Fixed by brave/brave-core#10123
Assignees
@onyb
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/No release-notes/exclude
Milestone
1.31.x - Release

Comments

@onyb
Copy link
Member

onyb commented Sep 16, 2021

The current way of searching through assets list in the wallet works fine, but has limitations when the list gets long or the users' search terms are approximate (ex, etherium vs ethereum). Use fuse.js instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.31.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): use Fuse.js for fuzzy-search in select-assets list brave/brave-core
1 participant
@onyb