Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Generate concrete classes for mojo generated interfaces that can be used for tests #20388

Closed
kylehickinson opened this issue Jan 7, 2022 · 0 comments · Fixed by brave/brave-core#11783
Closed

[iOS] Generate concrete classes for mojo generated interfaces that can be used for tests #20388

kylehickinson opened this issue Jan 7, 2022 · 0 comments · Fixed by brave/brave-core#11783
Assignees
@kylehickinson
Labels
dev-experience OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude
Milestone
1.36.x - Release

Comments

@kylehickinson
Copy link
Collaborator

Currently to handle testing in iOS for any generated mojo interface we have to create a conforming type and implement certain methods the way we want for certain tests.

We should use the same template code that generates the Obj-C interfaces to make concrete types that can setup any method for testing purposes.
@kylehickinson kylehickinson added QA/No dev-experience OS/iOS Fixes related to iOS browser functionality labels Jan 7, 2022
@kylehickinson kylehickinson self-assigned this Jan 7, 2022
@kylehickinson kylehickinson changed the title Generate concrete classes for mojo generated interfaces that can be used for tests [iOS] Generate concrete classes for mojo generated interfaces that can be used for tests Jan 7, 2022
@kylehickinson kylehickinson mentioned this issue Jan 7, 2022
Merged
25 tasks
@kylehickinson kylehickinson added this to the 1.36.x - Nightly milestone Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylehickinson kylehickinson

Labels
dev-experience OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude
Projects
None yet
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

Generate concrete classes for mojo generated interfaces for testing brave/brave-core
1 participant
@kylehickinson