Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button padding too large on wallet form #21056

Closed
Uni-verse opened this issue Feb 11, 2022 · 3 comments · Fixed by brave/brave-core#13069
Closed

Button padding too large on wallet form #21056

Uni-verse opened this issue Feb 11, 2022 · 3 comments · Fixed by brave/brave-core#13069
Assignees
@qamarngr
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.40.x - Release

Comments

@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 11, 2022 •
edited

Description

Button padding too large on wallet form

#20962

Steps to reproduce

  1. Tap menu > settings
  2. Select Brave Wallet
  3. Create wallets, skip back up
  4. From the wallet dashboard, access the settings menu
  5. Select Networks
  6. Select + Add Network
  7. Observe the button of the add network form

Actual result

Button too bulky for the text

Screenshot_20220211-232400_Brave - Nightly

Expected result

Padding should be reduced around the text

Issue reproduces how often

Easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung Galaxy S21 (2400x1080)
  • Android version: 12

Brave version

1.37.42, Chromium 98.0.4758.87

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information
@Uni-verse Uni-verse added bug QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Feb 11, 2022
@kjozwiak kjozwiak added this to Untriaged in Wallet via automation Feb 13, 2022
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 25, 2022
@bbondy bbondy moved this from Untriaged to Backlog (Android) in Wallet Feb 25, 2022
@bbondy bbondy removed this from Backlog (Android) in Wallet Mar 17, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Apr 11, 2022
Closed
@qamarngr qamarngr self-assigned this Apr 18, 2022
qamarngr added a commit to qamarngr/brave-core that referenced this issue Apr 18, 2022
@qamarngr
fixed add button on wallet add network
d08a8ac 
Fixes brave/brave-browser#22220
Fixes brave/brave-browser#21056
@qamarngr qamarngr mentioned this issue Apr 18, 2022
Closed
25 tasks
qamarngr added a commit to qamarngr/brave-core that referenced this issue Apr 19, 2022
@qamarngr
fixed alignment and styling of add button
5687557 
On the Screen
Settings->Brave Wallet-> Networks-> Add Network
Made the button center-aligned removed extra padding and used style BraveWalletButtonStyle

Fixes brave/brave-browser#22220
Fixes brave/brave-browser#21056
@qamarngr qamarngr mentioned this issue Apr 19, 2022
Merged
25 tasks
qamarngr added a commit to brave/brave-core that referenced this issue Apr 28, 2022
@qamarngr
Merge pull request #13069 from brave/
be1170a 
On the Screen
Settings->Brave Wallet-> Networks-> Add Network
Made the button center-aligned removed extra padding and used style BraveWalletButtonStyle

Fixes brave/brave-browser#22220
Fixes brave/brave-browser#21056
@qamarngr qamarngr added this to the 1.40.x - Nightly milestone May 4, 2022
@Uni-verse
Copy link
Contributor Author

Uni-verse commented Jun 2, 2022 •
edited

Reproduced on Samsung Galaxy S21 running Android 12 using version 1.40.75, Chromium 102.0.5005.61

  • Button still looks a little fat but is now center-aligned and contains margin between the bottom of the page.
Add Network Form Version
screenshot-1654188070613 screenshot-1654188090248

Just as a comparison, this is the Add account button on the accounts tab in brave wallet.

1 2
Screen Shot 2022-06-02 at 9 51 59 AM Screen Shot 2022-06-02 at 9 52 15 AM

@srirambv
Copy link
Contributor

cc: @jamesmudgett

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.40.105 x64 build

  • Verified button is as per spec
Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)

@Uni-verse the button seems to be as per spec. Please open a new issue for design discussion on different use of button styling and cc @jamesmudgett and @minkyeongshin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qamarngr qamarngr

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.40.x - Release
4 participants
@bbondy @qamarngr @srirambv @Uni-verse