Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ApprovedTxObserver global in wallet #21612

Closed
wchen342 opened this issue Mar 11, 2022 · 1 comment
Closed

Make ApprovedTxObserver global in wallet #21612

wchen342 opened this issue Mar 11, 2022 · 1 comment
Labels
closed/invalid feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude

Comments

@wchen342
Copy link

Currently ApprovedTxObserver is triggered on the activity which the bottom sheet is launched from. Need to make it global so pending tx notification, etc. are updated correctly.
@wchen342 wchen342 added QA/No release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Mar 11, 2022
@wchen342 wchen342 mentioned this issue Mar 15, 2022
Closed
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Backlog in Web3 Mar 18, 2022
@wchen342 wchen342 mentioned this issue Mar 23, 2022
Merged
25 tasks
@wchen342
Copy link
Author

Invalidated. See discussion at brave/brave-core/pull/12712.

Repository owner moved this from Backlog to Done in Web3 Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/invalid feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Projects
Web3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wchen342