Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky RequestAdsEnabledApiTestEnabled.RewardsEnablePopupAccepted browser tests #21809

Closed
aseren opened this issue Mar 22, 2022 · 5 comments · Fixed by brave/brave-core#12748
Closed

Fix flaky RequestAdsEnabledApiTestEnabled.RewardsEnablePopupAccepted browser tests #21809

aseren opened this issue Mar 22, 2022 · 5 comments · Fixed by brave/brave-core#12748
Assignees
@aseren
Labels
feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude tests
Projects
Ads
Milestone
1.37.x - Release #5

Comments

@aseren
Copy link

aseren commented Mar 22, 2022

Failure was seen here report
@aseren aseren self-assigned this Mar 22, 2022
@aseren aseren added this to New issues in Ads via automation Mar 22, 2022
@aseren aseren moved this from New issues to Sprint Candidates in Ads Mar 22, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Mar 22, 2022 •
edited
Loading

Seeing this happen via this PR which is uplifting C100 into 1.37.x via brave/brave-core#12683.

Adding stack within the issue as CI jobs are eventually removed:

[ RUN      ] RequestAdsEnabledApiTestEnabled.RewardsEnablePopupAccepted

[7208:10092:0321/145433.295:WARNING:external_provider_impl.cc(506)] Malformed extension dictionary for extension: odbfpeeihdkbihmopkbjmoonfanlbfcl.  Key external_update_url has value "", which is not a valid URL.
[7208:10092:0321/145433.359:ERROR:device_event_log_impl.cc(214)] [14:54:33.358] Bluetooth: bluetooth_adapter_winrt.cc:1075 Getting Default Adapter failed.
[7208:10092:0321/145433.947:INFO:ui_test_utils.cc(233)] NavigateToURL: https://talk.brave.com:58278/simple.html
[7208:10092:0321/145434.284:WARNING:CONSOLE(23460)] "no tab id so cannot request shield data from window focus change!", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/out/brave_extension_background.bundle.js (23460)
[9360:8032:0321/145434.294:ERROR:gl_utils.cc(319)] [.RendererMainThread-0000222C004C1B00]GL Driver Message (OpenGL, Performance, GL_CLOSE_PATH_NV, High): GPU stall due to ReadPixels
[9360:8032:0321/145434.297:ERROR:gl_utils.cc(319)] [.RendererMainThread-0000222C004C1B00]GL Driver Message (OpenGL, Performance, GL_CLOSE_PATH_NV, High): GPU stall due to ReadPixels
[9360:8032:0321/145434.298:ERROR:gl_utils.cc(319)] [.RendererMainThread-0000222C004C1B00]GL Driver Message (OpenGL, Performance, GL_CLOSE_PATH_NV, High): GPU stall due to ReadPixels
[9360:8032:0321/145434.298:ERROR:gl_utils.cc(319)] [.RendererMainThread-0000222C004C1B00]GL Driver Message (OpenGL, Performance, GL_CLOSE_PATH_NV, High): GPU stall due to ReadPixels (this message will no longer repeat)
[7208:10092:0321/145435.193:INFO:post_wallet_brave.cc(85)] Wallet is null
[7208:10092:0321/145435.193:INFO:rewards_service_impl.cc(3451)] Failed to create a wallet
[7208:10092:0321/145436.304:WARNING:brave_stats_updater_params.cc(134)] Couldn't find the time of first run. This should only happen when running tests, but never in production code.
content/public/test/browser_test_utils.cc(2659): error: Failed
RunLoop::Run() timed out. Timeout set at ProxyRunTestOnMainThreadLoop@content/public/test/browser_test_base.cc:809.

Stack trace:

Backtrace:

	base::internal::Invoker<base::internal::BindState<`lambda at ../../base/test/scoped_run_loop_timeout.cc:51:9',base::Location,base::RepeatingCallback<std::__1::basic_string<char,std::__1::char_traits<char>,std::__1::allocator<char> > ()> >,void (const base [0x00007FF73950B3A6+166] (C:\ws\src\base\bind_internal.h:761)

	base::`anonymous namespace'::OnRunLoopTimeout [0x00007FF73955ECCC+60] (C:\ws\src\base\run_loop.cc:48)
	base::internal::Invoker<base::internal::BindState<void (*)(base::RunLoop *, const base::Location &, base::OnceCallback<void (const base::Location &)>),base::internal::UnretainedWrapper<base::RunLoop>,base::Location,base::RepeatingCallback<void (const base [0x00007FF739560126+102] (C:\ws\src\base\bind_internal.h:748)
	base::internal::CancelableCallbackImpl<base::OnceCallback<void ()> >::ForwardOnce<> [0x00007FF73622AD7D+61] (C:\ws\src\base\cancelable_callback.h:128)
	base::TaskAnnotator::RunTaskImpl [0x00007FF73957C477+327] (C:\ws\src\base\task\common\task_annotator.cc:135)
	base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl [0x00007FF73ACA5803+403] (C:\ws\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:385)
	base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork [0x00007FF73ACA54CF+159] (C:\ws\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:296)
	base::MessagePumpForUI::DoRunLoop [0x00007FF7395B22B6+150] (C:\ws\src\base\message_loop\message_pump_win.cc:221)
	base::MessagePumpWin::Run [0x00007FF7395B1C31+129] (C:\ws\src\base\message_loop\message_pump_win.cc:79)
	base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run [0x00007FF73ACA603D+285] (C:\ws\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:500)
	base::RunLoop::Run [0x00007FF73955E599+553] (C:\ws\src\base\run_loop.cc:143)
	content::DOMMessageQueue::WaitForMessage [0x00007FF73A1A707E+172] (C:\ws\src\content\public\test\browser_test_utils.cc:2660)
	content::`anonymous namespace'::ExecuteScriptHelper [0x00007FF73A1A53B8+373] (C:\ws\src\content\public\test\browser_test_utils.cc:187)
	content::`anonymous namespace'::EvalRunnerScript [0x00007FF73A1A5D9B+209] (C:\ws\src\content\public\test\browser_test_utils.cc:1682)
	content::EvalJs [0x00007FF73A1A4CEB+397] (C:\ws\src\content\public\test\browser_test_utils.cc:1839)
	RequestAdsEnabledApiTestEnabled_RewardsEnablePopupAccepted_Test::RunTestOnMainThread [0x00007FF735D5409E+1198] (C:\ws\src\brave\browser\brave_ads\request_ads_enabled_api_browsertest.cc:229)
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF73A1A2EDE+750] (C:\ws\src\content\public\test\browser_test_base.cc:881)
	content::BrowserMainLoop::InterceptMainMessageLoopRun [0x00007FF7372F5E96+92] (C:\ws\src\content\browser\browser_main_loop.cc:1028)
	content::BrowserMainLoop::RunMainMessageLoop [0x00007FF7372F5EE3+37] (C:\ws\src\content\browser\browser_main_loop.cc:1040)
	content::BrowserMainRunnerImpl::Run [0x00007FF7372F7AD1+17] (C:\ws\src\content\browser\browser_main_runner_impl.cc:157)
	content::BrowserMain [0x00007FF7372F37E3+203] (C:\ws\src\content\browser\browser_main.cc:30)
	content::RunBrowserProcessMain [0x00007FF73810AD0F+239] (C:\ws\src\content\app\content_main_runner_impl.cc:642)
	content::ContentMainRunnerImpl::RunBrowser [0x00007FF73810BF35+1185] (C:\ws\src\content\app\content_main_runner_impl.cc:1175)
	content::ContentMainRunnerImpl::Run [0x00007FF73810BA5B+459] (C:\ws\src\content\app\content_main_runner_impl.cc:1046)
	content::RunContentProcess [0x00007FF73810A4C4+829] (C:\ws\src\content\app\content_main.cc:401)
	content::ContentMain [0x00007FF73810A89A+84] (C:\ws\src\content\app\content_main.cc:429)
	content::BrowserTestBase::SetUp [0x00007FF73A1A2522+1938] (C:\ws\src\content\public\test\browser_test_base.cc:717)
	InProcessBrowserTest::SetUp [0x00007FF73942DCFB+411] (C:\ws\src\chrome\test\base\in_process_browser_test.cc:462)
../../brave/browser/brave_ads/request_ads_enabled_api_browsertest.cc(229): error: Expected equality of these values:

  true

  content::EvalJs(contents, kResolveRequestAdsEnabledPromise)

    Which is: Internal Error: ExecuteScriptHelper failed

Stack trace:

Backtrace:

	RequestAdsEnabledApiTestEnabled_RewardsEnablePopupAccepted_Test::RunTestOnMainThread [0x00007FF735D5415F+1391] (C:\ws\src\brave\browser\brave_ads\request_ads_enabled_api_browsertest.cc:229)
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF73A1A2EDE+750] (C:\ws\src\content\public\test\browser_test_base.cc:881)
	content::BrowserMainLoop::InterceptMainMessageLoopRun [0x00007FF7372F5E96+92] (C:\ws\src\content\browser\browser_main_loop.cc:1028)
	content::BrowserMainLoop::RunMainMessageLoop [0x00007FF7372F5EE3+37] (C:\ws\src\content\browser\browser_main_loop.cc:1040)
	content::BrowserMainRunnerImpl::Run [0x00007FF7372F7AD1+17] (C:\ws\src\content\browser\browser_main_runner_impl.cc:157)
	content::BrowserMain [0x00007FF7372F37E3+203] (C:\ws\src\content\browser\browser_main.cc:30)
	content::RunBrowserProcessMain [0x00007FF73810AD0F+239] (C:\ws\src\content\app\content_main_runner_impl.cc:642)
	content::ContentMainRunnerImpl::RunBrowser [0x00007FF73810BF35+1185] (C:\ws\src\content\app\content_main_runner_impl.cc:1175)
	content::ContentMainRunnerImpl::Run [0x00007FF73810BA5B+459] (C:\ws\src\content\app\content_main_runner_impl.cc:1046)
	content::RunContentProcess [0x00007FF73810A4C4+829] (C:\ws\src\content\app\content_main.cc:401)
	content::ContentMain [0x00007FF73810A89A+84] (C:\ws\src\content\app\content_main.cc:429)
	content::BrowserTestBase::SetUp [0x00007FF73A1A2522+1938] (C:\ws\src\content\public\test\browser_test_base.cc:717)
	InProcessBrowserTest::SetUp [0x00007FF73942DCFB+411] (C:\ws\src\chrome\test\base\in_process_browser_test.cc:462)
../../brave/browser/brave_ads/request_ads_enabled_api_browsertest.cc(230): error: Value of: GetPrefs()->GetBoolean(ads::prefs::kEnabled)

  Actual: false

Expected: true

Stack trace:

Backtrace:

	RequestAdsEnabledApiTestEnabled_RewardsEnablePopupAccepted_Test::RunTestOnMainThread [0x00007FF735D54292+1698] (C:\ws\src\brave\browser\brave_ads\request_ads_enabled_api_browsertest.cc:230)
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF73A1A2EDE+750] (C:\ws\src\content\public\test\browser_test_base.cc:881)
	content::BrowserMainLoop::InterceptMainMessageLoopRun [0x00007FF7372F5E96+92] (C:\ws\src\content\browser\browser_main_loop.cc:1028)
	content::BrowserMainLoop::RunMainMessageLoop [0x00007FF7372F5EE3+37] (C:\ws\src\content\browser\browser_main_loop.cc:1040)
	content::BrowserMainRunnerImpl::Run [0x00007FF7372F7AD1+17] (C:\ws\src\content\browser\browser_main_runner_impl.cc:157)
	content::BrowserMain [0x00007FF7372F37E3+203] (C:\ws\src\content\browser\browser_main.cc:30)
	content::RunBrowserProcessMain [0x00007FF73810AD0F+239] (C:\ws\src\content\app\content_main_runner_impl.cc:642)
	content::ContentMainRunnerImpl::RunBrowser [0x00007FF73810BF35+1185] (C:\ws\src\content\app\content_main_runner_impl.cc:1175)
	content::ContentMainRunnerImpl::Run [0x00007FF73810BA5B+459] (C:\ws\src\content\app\content_main_runner_impl.cc:1046)
	content::RunContentProcess [0x00007FF73810A4C4+829] (C:\ws\src\content\app\content_main.cc:401)
	content::ContentMain [0x00007FF73810A89A+84] (C:\ws\src\content\app\content_main.cc:429)
	content::BrowserTestBase::SetUp [0x00007FF73A1A2522+1938] (C:\ws\src\content\public\test\browser_test_base.cc:717)
	InProcessBrowserTest::SetUp [0x00007FF73942DCFB+411] (C:\ws\src\chrome\test\base\in_process_browser_test.cc:462)

[7208:10092:0321/145507.413:WARNING:task_environment.cc(799)] ParallelExecutionFence is ineffective when ThreadPoolInstance is not managed by a TaskEnvironment.
Test fixtures should use a TaskEnvironment member or statically invoke TaskEnvironment::CreateThreadPool() + ThreadPoolInstance::Get()->StartWithDefaultParams() when the former is not possible.
[7208:10092:0321/145507.413:WARNING:task_environment.cc(799)] ParallelExecutionFence is ineffective when ThreadPoolInstance is not managed by a TaskEnvironment.
Test fixtures should use a TaskEnvironment member or statically invoke TaskEnvironment::CreateThreadPool() + ThreadPoolInstance::Get()->StartWithDefaultParams() when the former is not possible.
[7208:10092:0321/145507.414:WARNING:task_environment.cc(799)] ParallelExecutionFence is ineffective when ThreadPoolInstance is not managed by a TaskEnvironment.
Test fixtures should use a TaskEnvironment member or statically invoke TaskEnvironment::CreateThreadPool() + ThreadPoolInstance::Get()->StartWithDefaultParams() when the former is not possible.

[  FAILED  ] RequestAdsEnabledApiTestEnabled.RewardsEnablePopupAccepted, where TypeParam =  and GetParam() =  (34167 ms)

@kjozwiak kjozwiak changed the title Fix flaky RequestAdsEnabledApiTestEnabled browser tests Fix flaky RequestAdsEnabledApiTestEnabled browser tests Mar 22, 2022
@kjozwiak kjozwiak changed the title Fix flaky RequestAdsEnabledApiTestEnabled browser tests Fix flaky RequestAdsEnabledApiTestEnabled.RewardsEnablePopupAccepted browser tests Mar 22, 2022
@kjozwiak kjozwiak mentioned this issue Mar 22, 2022
Merged
25 tasks
@ShivanKaul ShivanKaul mentioned this issue Mar 23, 2022
Merged
25 tasks
@aseren aseren moved this from Sprint Candidates to In progress in Ads Mar 23, 2022
@tmancey tmancey added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 23, 2022
@kjozwiak kjozwiak mentioned this issue Mar 24, 2022
Merged
7 tasks
aseren added a commit to brave/brave-core that referenced this issue Mar 25, 2022
@aseren
Set brave wallet preference synchronously.
46bb7db 
fix brave/brave-browser#21809
aseren added a commit to brave/brave-core that referenced this issue Mar 25, 2022
@aseren
Set brave wallet string state synchronously.
6c98da0 
fix brave/brave-browser#21809
@aseren aseren mentioned this issue Mar 25, 2022
Merged
25 tasks
@aseren aseren moved this from In progress to Review in Ads Mar 25, 2022
@kjozwiak kjozwiak mentioned this issue Mar 28, 2022
Merged
7 tasks
Ads automation moved this from Review to Done Mar 28, 2022
@aseren aseren added this to the 1.39.x - Nightly milestone Mar 28, 2022
This was referenced Mar 29, 2022
Merged
Merged
@aseren aseren added QA/Yes and removed QA/No labels Mar 29, 2022
This was referenced Mar 29, 2022
Merged
Merged
@kjozwiak kjozwiak mentioned this issue Apr 1, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Apr 5, 2022

The above requires 1.37.112 or higher for 1.37.x verification.

@btlechowski
Copy link

Verification passed on

Brave 1.37.113 Chromium: 100.0.4896.88 (Official Build) (64-bit)
Revision 4450653bfa91182e85723d8f1dee64dd6ce40ed4-refs/branch-heads/4896@{#1086}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#12748

Verified that creating a Brave Wallet via brave://wallet worked without any issues on clean install

Verified rewards wallet was created on clean install:
image

Verified able to view an ad

[18604:18604:0412/151507.158820:VERBOSE1:ad_notification_serving.cc(261)] Serving ad notification:
  uuid: d870bc04-06d5-463a-aa70-45f7162c963b
  creativeInstanceId: c6a6b939-4167-41fb-8a84-1edde6c12250
  creativeSetId: 45ea5952-37ca-41f0-88c2-4b546b0e6f4b
  campaignId: 1c1ac828-db13-49bb-9128-090132044b7f
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad8
  body: Ad8
  targetUrl: https://brave.com

Verified being paid for the ad

[18604:18604:0412/151507.206366:VERBOSE3:ads_impl.cc(778)] Successfully processed deposit for ad_notification with creative instance id c6a6b939-4167-41fb-8a84-1edde6c12250 and view valued at 0.01
Successfully redeemed unblinded token for ad_notification with confirmation id db9e0e9f-682b-4788-affd-6034912ee486, transaction id 10d51462-f89f-4bc3-8c0d-0b2acc274b3b, creative instance id c6a6b939-4167-41fb-8a84-1edde6c12250 and view.

image

Verified able to tip
image

[19326:19326:0412/152019.017363:VERBOSE1:contribution.cc(388)] Creating contribution for wallet type blinded (amount: 1.25, type: ONE_TIME_TIP)

image

@LaurenWags
Copy link
Member

LaurenWags commented Apr 12, 2022 •
edited
Loading

Verification in progress with

Brave | 1.37.113 Chromium: 100.0.4896.88 (Official Build) (x86_64)
-- | --
Revision | 4450653bfa91182e85723d8f1dee64dd6ce40ed4-refs/branch-heads/4896@{#1086}
OS | macOS Version 12.3.1 (Build 21E258)

Verified test plan from brave/brave-core#12748 (comment)

  • Confirmed that creating a Brave Wallet via brave://wallet worked without any issues on new profiles
  • Confirmed that users can trigger ad notifications and are being credited
[54065:259:0412/094659.941347:VERBOSE1:ad_notification_serving.cc(261)] Serving ad notification:
  uuid: faa24a28-806a-45ac-ba42-d4c1bd79776a
  creativeInstanceId: e48b259d-6a0d-4ba3-9809-3b3dd023f00f
  creativeSetId: cf8d206e-f788-4f2d-ad57-38a4fc8f3450
  campaignId: 0190443d-5138-4190-a86b-4c08f6d9b56d
  advertiserId: 8cfac071-75f8-46ab-9c7f-4f8420d914d7
  segment: untargeted
  title: Netlify - Build a Better Web
  body: The Fastest Way to Build, Deploy & Scale Modern Web3 Apps
  targetUrl: https://www.netlify.com/brave?utm_source=brave&utm_medium=display

[54065:259:0412/094700.030512:VERBOSE1:redeem_unblinded_token.cc(56)] Redeem unblinded token
[54065:259:0412/094700.030750:VERBOSE1:redeem_unblinded_token.cc(76)] CreateConfirmation
[54065:259:0412/094700.030798:VERBOSE2:redeem_unblinded_token.cc(77)] POST /v2/confirmation/{confirmation_id}/{credential}
[54065:259:0412/094700.030825:VERBOSE6:redeem_unblinded_token.cc(81)] URL Request:
  URL: https://ads-serve.brave.com/v2/confirmation/ea575601-171d-4b82-b93a-28ba495b2200/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlbnNcIjpbXCJyRFlJMVY3UHVkeWN1S1Y3T2pncElRc3dXVklCUS9nemhPc3lOU0VYVVNvPVwiXSxcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY291bnRyeUNvZGVcIjpcIlVTXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcImU0OGIyNTlkLTZhMGQtNGJhMy05ODA5LTNiM2RkMDIzZjAwZlwiLFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcIm1hY29zXCIsXCJwdWJsaWNLZXlcIjpcIkxBcUp4ZnlYZ1duNTJYUUFxcUVYTzBQL1Y0NnVaY1NJL29YTGRad3pBZ0U9XCIsXCJzdHVkaWVzXCI6W10sXCJ0eXBlXCI6XCJ2aWV3XCJ9Iiwic2lnbmF0dXJlIjoiMjg2cjllTXU0TWVlWjhScTVtdlRRdmE1ZWxvb2k1T3NoeUxFWDJEL1ZOSWVWd1poZ0xrMG1RS2FTcHkxL1lSYzdnOTRGeVdtNzZ4VEtXVm1xZHZlaUE9PSIsInQiOiI1cTQvNU52bTN0V2prb1c5UjZEYTBKYkx5SE9OTXcvVEtsdjZMOW01bkpqVWQ2c3JjS3ZTVEtJR3NsVWxadDUwbS9BdnBnbFl3bTkyNEtXSTZ5VjZvUT09In0=
  Content: {"blindedPaymentTokens":["rDYI1V7PudycuKV7OjgpIQswWVIBQ/gzhOsyNSEXUSo="],"buildChannel":"release","countryCode":"US","creativeInstanceId":"e48b259d-6a0d-4ba3-9809-3b3dd023f00f","payload":{},"platform":"macos","publicKey":"LAqJxfyXgWn52XQAqqEXO0P/V46uZcSI/oXLdZwzAgE=","studies":[],"type":"view"}
  Content Type: application/json
  Method: kPost
[54065:259:0412/094700.129408:VERBOSE1:redeem_unblinded_token.cc(92)] OnCreateConfirmation
[54065:259:0412/094700.129462:VERBOSE6:redeem_unblinded_token.cc(94)] URL Response:
  URL: https://ads-serve.brave.com/v2/confirmation/ea575601-171d-4b82-b93a-28ba495b2200/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlbnNcIjpbXCJyRFlJMVY3UHVkeWN1S1Y3T2pncElRc3dXVklCUS9nemhPc3lOU0VYVVNvPVwiXSxcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY291bnRyeUNvZGVcIjpcIlVTXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcImU0OGIyNTlkLTZhMGQtNGJhMy05ODA5LTNiM2RkMDIzZjAwZlwiLFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcIm1hY29zXCIsXCJwdWJsaWNLZXlcIjpcIkxBcUp4ZnlYZ1duNTJYUUFxcUVYTzBQL1Y0NnVaY1NJL29YTGRad3pBZ0U9XCIsXCJzdHVkaWVzXCI6W10sXCJ0eXBlXCI6XCJ2aWV3XCJ9Iiwic2lnbmF0dXJlIjoiMjg2cjllTXU0TWVlWjhScTVtdlRRdmE1ZWxvb2k1T3NoeUxFWDJEL1ZOSWVWd1poZ0xrMG1RS2FTcHkxL1lSYzdnOTRGeVdtNzZ4VEtXVm1xZHZlaUE9PSIsInQiOiI1cTQvNU52bTN0V2prb1c5UjZEYTBKYkx5SE9OTXcvVEtsdjZMOW01bkpqVWQ2c3JjS3ZTVEtJR3NsVWxadDUwbS9BdnBnbFl3bTkyNEtXSTZ5VjZvUT09In0=
  Response Status Code: 201
  Response: {"id":"ea575601-171d-4b82-b93a-28ba495b2200","payload":{},"createdAt":"2022-04-12T13:47:00.222Z","type":"view","modifiedAt":"2022-04-12T13:47:00.222Z","creativeInstanceId":"e48b259d-6a0d-4ba3-9809-3b3dd023f00f"}
[54065:259:0412/094700.129568:VERBOSE1:redeem_unblinded_token.cc(121)] FetchPaymentToken
[54065:259:0412/094700.129601:VERBOSE2:redeem_unblinded_token.cc(122)] GET /v2/confirmation/{confirmation_id}/paymentToken
[54065:259:0412/094700.129624:VERBOSE6:redeem_unblinded_token.cc(126)] URL Request:
  URL: https://ads-serve.brave.com/v2/confirmation/ea575601-171d-4b82-b93a-28ba495b2200/paymentToken
  Method: kGet
[54065:259:0412/094700.267973:VERBOSE1:redeem_unblinded_token.cc(137)] OnFetchPaymentToken
[54065:259:0412/094700.268029:VERBOSE6:redeem_unblinded_token.cc(139)] URL Response:
  URL: https://ads-serve.brave.com/v2/confirmation/ea575601-171d-4b82-b93a-28ba495b2200/paymentToken
  Response Status Code: 404
  Response: {"error":"Confirmation does not exist","statusCode":404}
[54065:259:0412/094700.268065:VERBOSE1:redeem_unblinded_token.cc(143)] Confirmation not found
[54065:259:0412/094700.268085:VERBOSE1:confirmations.cc(320)] Failed to redeem unblinded token for ad_notification with confirmation id ea575601-171d-4b82-b93a-28ba495b2200, transaction id 0fdf4578-05c4-4752-9b4c-1d260f031027, creative instance id e48b259d-6a0d-4ba3-9809-3b3dd023f00f and view
[54065:259:0412/094700.268986:VERBOSE1:confirmations.cc(205)] Added view confirmation for ad_notification with id eca996b9-4624-4a22-82ff-9fe7c9f3f046, transaction id0fdf4578-05c4-4752-9b4c-1d260f031027 and creative instance id e48b259d-6a0d-4ba3-9809-3b3dd023f00f to the confirmations queue
[54065:259:0412/094700.269274:VERBOSE1:refill_unblinded_tokens.cc(84)] No need to refill unblinded tokens as we already have 48 unblinded tokens which is above the minimum threshold of 20
[54065:259:0412/094700.269454:VERBOSE1:confirmations.cc(101)] Retry sending failed confirmations in 0 hours, 0 minutes, 9 seconds at 9:47 AM

[54065:259:0412/094709.271703:VERBOSE1:confirmations.cc(229)] Removed view confirmation for ad_notification with id eca996b9-4624-4a22-82ff-9fe7c9f3f046, transaction id 0fdf4578-05c4-4752-9b4c-1d260f031027 and creative instance id e48b259d-6a0d-4ba3-9809-3b3dd023f00f from the confirmations queue
[54065:259:0412/094709.271972:VERBOSE1:redeem_unblinded_token.cc(56)] Redeem unblinded token
[54065:259:0412/094709.272310:VERBOSE1:redeem_unblinded_token.cc(76)] CreateConfirmation
[54065:259:0412/094709.272360:VERBOSE2:redeem_unblinded_token.cc(77)] POST /v2/confirmation/{confirmation_id}/{credential}
[54065:259:0412/094709.272381:VERBOSE6:redeem_unblinded_token.cc(81)] URL Request:
  URL: https://ads-serve.brave.com/v2/confirmation/eca996b9-4624-4a22-82ff-9fe7c9f3f046/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlbnNcIjpbXCIvSmY4NWNtaFpvUll2a1hLSXRoZzlldzFDSDVFRmYwOVhxdFBMbk1TZkFJPVwiXSxcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY291bnRyeUNvZGVcIjpcIlVTXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcImU0OGIyNTlkLTZhMGQtNGJhMy05ODA5LTNiM2RkMDIzZjAwZlwiLFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcIm1hY29zXCIsXCJwdWJsaWNLZXlcIjpcIkxBcUp4ZnlYZ1duNTJYUUFxcUVYTzBQL1Y0NnVaY1NJL29YTGRad3pBZ0U9XCIsXCJzdHVkaWVzXCI6W10sXCJ0eXBlXCI6XCJ2aWV3XCJ9Iiwic2lnbmF0dXJlIjoicktHZjE0bjlmOUpVNm5nWEZsdVh2TlMxQmRxWURtWHFMUzNLOXA2ZUdOOHpvZW03VHh0NHZUdThFWjhTczA1TTgvTmdwenI0MTVxbmo1VXp5Q2h6WWc9PSIsInQiOiJnYjh4M0ZXbGlMb3k2TjRKY3BOdEdkVmJpMU02MkI0MVppKytzSkNBeG1oSlh3bStGVDZ0Uk05aExMT1BaaVZFb3pKdzJpYUgvMHJ5NkJpOXk3ZlFmdz09In0=
  Content: {"blindedPaymentTokens":["/Jf85cmhZoRYvkXKIthg9ew1CH5EFf09XqtPLnMSfAI="],"buildChannel":"release","countryCode":"US","creativeInstanceId":"e48b259d-6a0d-4ba3-9809-3b3dd023f00f","payload":{},"platform":"macos","publicKey":"LAqJxfyXgWn52XQAqqEXO0P/V46uZcSI/oXLdZwzAgE=","studies":[],"type":"view"}
  Content Type: application/json
  Method: kPost
[54065:259:0412/094709.386890:VERBOSE1:redeem_unblinded_token.cc(92)] OnCreateConfirmation
[54065:259:0412/094709.386941:VERBOSE6:redeem_unblinded_token.cc(94)] URL Response:
  URL: https://ads-serve.brave.com/v2/confirmation/eca996b9-4624-4a22-82ff-9fe7c9f3f046/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlbnNcIjpbXCIvSmY4NWNtaFpvUll2a1hLSXRoZzlldzFDSDVFRmYwOVhxdFBMbk1TZkFJPVwiXSxcImJ1aWxkQ2hhbm5lbFwiOlwicmVsZWFzZVwiLFwiY291bnRyeUNvZGVcIjpcIlVTXCIsXCJjcmVhdGl2ZUluc3RhbmNlSWRcIjpcImU0OGIyNTlkLTZhMGQtNGJhMy05ODA5LTNiM2RkMDIzZjAwZlwiLFwicGF5bG9hZFwiOnt9LFwicGxhdGZvcm1cIjpcIm1hY29zXCIsXCJwdWJsaWNLZXlcIjpcIkxBcUp4ZnlYZ1duNTJYUUFxcUVYTzBQL1Y0NnVaY1NJL29YTGRad3pBZ0U9XCIsXCJzdHVkaWVzXCI6W10sXCJ0eXBlXCI6XCJ2aWV3XCJ9Iiwic2lnbmF0dXJlIjoicktHZjE0bjlmOUpVNm5nWEZsdVh2TlMxQmRxWURtWHFMUzNLOXA2ZUdOOHpvZW03VHh0NHZUdThFWjhTczA1TTgvTmdwenI0MTVxbmo1VXp5Q2h6WWc9PSIsInQiOiJnYjh4M0ZXbGlMb3k2TjRKY3BOdEdkVmJpMU02MkI0MVppKytzSkNBeG1oSlh3bStGVDZ0Uk05aExMT1BaaVZFb3pKdzJpYUgvMHJ5NkJpOXk3ZlFmdz09In0=
  Response Status Code: 201
  Response: {"id":"eca996b9-4624-4a22-82ff-9fe7c9f3f046","payload":{},"createdAt":"2022-04-12T13:47:09.468Z","type":"view","modifiedAt":"2022-04-12T13:47:09.468Z","creativeInstanceId":"e48b259d-6a0d-4ba3-9809-3b3dd023f00f"}
[54065:259:0412/094709.387039:VERBOSE1:redeem_unblinded_token.cc(121)] FetchPaymentToken
[54065:259:0412/094709.387071:VERBOSE2:redeem_unblinded_token.cc(122)] GET /v2/confirmation/{confirmation_id}/paymentToken
[54065:259:0412/094709.387093:VERBOSE6:redeem_unblinded_token.cc(126)] URL Request:
  URL: https://ads-serve.brave.com/v2/confirmation/eca996b9-4624-4a22-82ff-9fe7c9f3f046/paymentToken
  Method: kGet
[54065:259:0412/094709.470765:VERBOSE1:redeem_unblinded_token.cc(137)] OnFetchPaymentToken
[54065:259:0412/094709.470822:VERBOSE6:redeem_unblinded_token.cc(139)] URL Response:
  URL: https://ads-serve.brave.com/v2/confirmation/eca996b9-4624-4a22-82ff-9fe7c9f3f046/paymentToken
  Response Status Code: 202
  Response: {"error":"Payment Tokens are not ready","statusCode":202}
[54065:259:0412/094709.470857:VERBOSE1:redeem_unblinded_token.cc(159)] Payment token is not ready
[54065:259:0412/094709.470879:VERBOSE1:confirmations.cc(320)] Failed to redeem unblinded token for ad_notification with confirmation id eca996b9-4624-4a22-82ff-9fe7c9f3f046, transaction id 0fdf4578-05c4-4752-9b4c-1d260f031027, creative instance id e48b259d-6a0d-4ba3-9809-3b3dd023f00f and view
[54065:259:0412/094709.471174:VERBOSE1:confirmations.cc(205)] Added view confirmation for ad_notification with id eca996b9-4624-4a22-82ff-9fe7c9f3f046, transaction id0fdf4578-05c4-4752-9b4c-1d260f031027 and creative instance id e48b259d-6a0d-4ba3-9809-3b3dd023f00f to the confirmations queue
[54065:259:0412/094709.471390:VERBOSE1:refill_unblinded_tokens.cc(84)] No need to refill unblinded tokens as we already have 48 unblinded tokens which is above the minimum threshold of 20
[54065:259:0412/094709.471602:VERBOSE1:confirmations.cc(101)] Retry sending failed confirmations in 0 hours, 0 minutes, 1 second at 9:47 AM
[54065:259:0412/094710.475160:VERBOSE1:confirmations.cc(229)] Removed view confirmation for ad_notification with id eca996b9-4624-4a22-82ff-9fe7c9f3f046, transaction id 0fdf4578-05c4-4752-9b4c-1d260f031027 and creative instance id e48b259d-6a0d-4ba3-9809-3b3dd023f00f from the confirmations queue
[54065:259:0412/094710.475413:VERBOSE1:redeem_unblinded_token.cc(56)] Redeem unblinded token
[54065:259:0412/094710.475703:VERBOSE1:redeem_unblinded_token.cc(121)] FetchPaymentToken
[54065:259:0412/094710.475744:VERBOSE2:redeem_unblinded_token.cc(122)] GET /v2/confirmation/{confirmation_id}/paymentToken
[54065:259:0412/094710.475769:VERBOSE6:redeem_unblinded_token.cc(126)] URL Request:
  URL: https://ads-serve.brave.com/v2/confirmation/eca996b9-4624-4a22-82ff-9fe7c9f3f046/paymentToken
  Method: kGet
[54065:259:0412/094710.557054:VERBOSE1:redeem_unblinded_token.cc(137)] OnFetchPaymentToken
[54065:259:0412/094710.557106:VERBOSE6:redeem_unblinded_token.cc(139)] URL Response:
  URL: https://ads-serve.brave.com/v2/confirmation/eca996b9-4624-4a22-82ff-9fe7c9f3f046/paymentToken
  Response Status Code: 202
  Response: {"error":"Payment Tokens are not ready","statusCode":202}
[54065:259:0412/094710.557139:VERBOSE1:redeem_unblinded_token.cc(159)] Payment token is not ready
[54065:259:0412/094710.557160:VERBOSE1:confirmations.cc(320)] Failed to redeem unblinded token for ad_notification with confirmation id eca996b9-4624-4a22-82ff-9fe7c9f3f046, transaction id 0fdf4578-05c4-4752-9b4c-1d260f031027, creative instance id e48b259d-6a0d-4ba3-9809-3b3dd023f00f and view
[54065:259:0412/094710.557377:VERBOSE1:confirmations.cc(205)] Added view confirmation for ad_notification with id eca996b9-4624-4a22-82ff-9fe7c9f3f046, transaction id0fdf4578-05c4-4752-9b4c-1d260f031027 and creative instance id e48b259d-6a0d-4ba3-9809-3b3dd023f00f to the confirmations queue
[54065:259:0412/094710.557590:VERBOSE1:refill_unblinded_tokens.cc(84)] No need to refill unblinded tokens as we already have 48 unblinded tokens which is above the minimum threshold of 20
[54065:259:0412/094710.557781:VERBOSE1:confirmations.cc(101)] Retry sending failed confirmations in 0 hours, 5 minutes, 54 seconds at 9:53 AM
[54065:259:0412/094712.913274:VERBOSE1:redeem_unblinded_payment_tokens.cc(82)] RedeemUnblindedPaymentTokens
[54065:259:0412/094712.913327:VERBOSE1:redeem_unblinded_payment_tokens.cc(85)] No unblinded payment tokens to redeem
[54065:259:0412/094712.913716:VERBOSE1:redeem_unblinded_payment_tokens.cc(74)] Redeem unblinded payment tokens in 17 hours, 55 minutes, 27 seconds at 3:42 AM
[54065:259:0412/095304.554948:VERBOSE1:confirmations.cc(229)] Removed view confirmation for ad_notification with id eca996b9-4624-4a22-82ff-9fe7c9f3f046, transaction id 0fdf4578-05c4-4752-9b4c-1d260f031027 and creative instance id e48b259d-6a0d-4ba3-9809-3b3dd023f00f from the confirmations queue
[54065:259:0412/095304.555239:VERBOSE1:redeem_unblinded_token.cc(56)] Redeem unblinded token
[54065:259:0412/095304.555625:VERBOSE1:redeem_unblinded_token.cc(121)] FetchPaymentToken
[54065:259:0412/095304.555661:VERBOSE2:redeem_unblinded_token.cc(122)] GET /v2/confirmation/{confirmation_id}/paymentToken
[54065:259:0412/095304.555682:VERBOSE6:redeem_unblinded_token.cc(126)] URL Request:
  URL: https://ads-serve.brave.com/v2/confirmation/eca996b9-4624-4a22-82ff-9fe7c9f3f046/paymentToken
  Method: kGet
[54065:259:0412/095304.790346:VERBOSE1:redeem_unblinded_token.cc(137)] OnFetchPaymentToken
[54065:259:0412/095304.790441:VERBOSE6:redeem_unblinded_token.cc(139)] URL Response:
  URL: https://ads-serve.brave.com/v2/confirmation/eca996b9-4624-4a22-82ff-9fe7c9f3f046/paymentToken
  Response Status Code: 200
  Response: {"id":"eca996b9-4624-4a22-82ff-9fe7c9f3f046","createdAt":"2022-04-12T13:47:09.468Z","type":"view","modifiedAt":"2022-04-12T13:47:11.813Z","creativeInstanceId":"e48b259d-6a0d-4ba3-9809-3b3dd023f00f","paymentToken":{"publicKey":"NvXN4/DCTDZrtk7msAMrTL3hVh5Het1GNzfxkWUCWzU=","batchProof":"x6a6KRphCAqCczfsazUVMprEsgBFsNP97e+2oSgPXQXRnZIaDekRAemGBOGbWHJIP+aHPO5B5OMsk12eLtdiAQ==","signedTokens":["ohfh/DP3lGLwPpZhxKu/WuPc+MELNcSvAKZpE4l/fhk="]}}
[54065:259:0412/095304.791452:VERBOSE1:confirmations.cc(301)] Successfully redeemed unblinded token for ad_notification with confirmation id eca996b9-4624-4a22-82ff-9fe7c9f3f046, transaction id 0fdf4578-05c4-4752-9b4c-1d260f031027, creative instance id e48b259d-6a0d-4ba3-9809-3b3dd023f00f and view. You now have 1 unblinded payment tokens which will be redeemed in 17 hours, 49 minutes, 35 seconds at 3:42 AM
[54065:259:0412/095304.791766:VERBOSE1:refill_unblinded_tokens.cc(84)] No need to refill unblinded tokens as we already have 48 unblinded tokens which is above the minimum threshold of 20
Example Example
Screen Shot 2022-04-12 at 9 59 41 AM Screen Shot 2022-04-12 at 9 59 46 AM
  • Confirmed able to tip using anon (UGP funded):
[55111:259:0412/102426.309598:VERBOSE1:contribution.cc(388)] Creating contribution for wallet type blinded (amount: 5, type: ONE_TIME_TIP)
Example Example
Screen Shot 2022-04-12 at 10 25 31 AM Screen Shot 2022-04-12 at 10 25 38 AM
  • Confirmed able to tip using Uphold:
[55294:259:0412/102724.561154:VERBOSE1:contribution.cc(388)] Creating contribution for wallet type uphold (amount: 1, type: ONE_TIME_TIP)
Example Example Example
Screen Shot 2022-04-12 at 10 33 05 AM Screen Shot 2022-04-12 at 10 33 11 AM Screen Shot 2022-04-12 at 10 33 26 AM
  • Confirmed able to tip using Gemini:
[55599:259:0412/103727.727541:VERBOSE1:contribution.cc(388)] Creating contribution for wallet type gemini (amount: 2, type: ONE_TIME_TIP)
Example Example Example
Screen Shot 2022-04-12 at 10 47 06 AM Screen Shot 2022-04-12 at 10 47 30 AM Screen Shot 2022-04-12 at 10 47 20 AM

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 12, 2022 •
edited
Loading

Verification PASSED on

Brave | 1.37.113 Chromium: 100.0.4896.88 (Official Build) (64-bit)
-- | --
Revision | 4450653bfa91182e85723d8f1dee64dd6ce40ed4-refs/branch-heads/4896@{#1086}
OS | Windows 10 Version 21H2 (Build 19044.1586)

Confirm Ads are served:

[20652:1508:0412/194102.478:VERBOSE1:ad_notification_serving.cc(261)] Serving ad notification:
  uuid: 9691d83b-13aa-47e5-9d88-6b8772be7032
  creativeInstanceId: 04064736-ea43-463a-bd6e-6c2be4408b4d
  creativeSetId: 45ea5952-37ca-41f0-88c2-4b546b0e6f4b
  campaignId: 1c1ac828-db13-49bb-9128-090132044b7f
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad10
  body: Ad10
  targetUrl: https://brave.com
[20652:1508:0412/194102.484:INFO:notification_helper_win.cc(187)] Notifications are enabled
[20652:1508:0412/194102.485:INFO:notification_helper_win.cc(154)] Focus Assist is disabled
[20652:1508:0412/194102.489:VERBOSE1:ads_service_impl.cc(1911)] Timeout ad notification with uuid 9691d83b-13aa-47e5-9d88-6b8772be7032 in 120 seconds
[20652:1508:0412/194102.492:VERBOSE3:ad_notification_event_served.cc(24)] Served ad notification with uuid 9691d83b-13aa-47e5-9d88-6b8772be7032 and creative instance id 04064736-ea43-463a-bd6e-6c2be4408b4d
[20652:1508:0412/194102.493:VERBOSE1:ad_notification_serving.cc(154)] Served ad notification
[20652:1508:0412/194102.498:VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid 9691d83b-13aa-47e5-9d88-6b8772be7032 and creative instance id 04064736-ea43-463a-bd6e-6c2be4408b4d

Confirm uses are rewarded for viewing an Ad

[20652:1508:0412/194102.528:VERBOSE3:ads_impl.cc(778)] Successfully processed deposit for ad_notification with creative instance id 04064736-ea43-463a-bd6e-6c2be4408b4d and view valued at 0.01
[20652:1508:0412/194102.529:VERBOSE1:confirmations.cc(61)] Confirming view for ad_notification with transaction id 99f1c8e5-2b55-423e-8509-42a49848e6fc and creative instance id 04064736-ea43-463a-bd6e-6c2be4408b4d
Ads panel Ads history
image image

Verified able to tip:

Example Example
image image 
[20652:1508:0412/195414.617:VERBOSE1:contribution.cc(388)] Creating contribution for wallet type blinded (amount: 10, type: ONE_TIME_TIP)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude tests
Projects
Ads
Archived in project
Ads
  
Done
Milestone
1.37.x - Release #5
Development

Successfully merging a pull request may close this issue.

Set brave wallet string state synchronously. brave/brave-core
6 participants
@tmancey @kjozwiak @LaurenWags @btlechowski @GeetaSarvadnya @aseren