Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Fix NTP SI, imagecredit cutoff (uplift to 1.37.x) #12752

Merged

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Mar 25, 2022

Uplift of #12711
Resolves brave/brave-browser#21736

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team March 25, 2022 14:44
@brave-builds brave-builds self-assigned this Mar 25, 2022
@brave-builds brave-builds added this to the 1.37.x - Release milestone Mar 25, 2022
@kjozwiak
Copy link
Member

Windows failed test-browser due to RequestAdsEnabledApiTestEnabled.RewardsEnablePopupAccepted failing as per https://ci.brave.com/job/pr-brave-browser-pr12711_ntp_si_imagecredit_cutoff_fixes_android_1.37.x-windows/1/testReport/(root)/RequestAdsEnabledApiTestEnabled/windows_x64___test_browser___RewardsEnablePopupAccepted/. However, this is a known intermittent failure as per brave/brave-browser#21809 and doesn't block uplift.

Linux failed due to the test-unit-chromium tests failing as per https://ci.brave.com/job/pr-brave-browser-pr12711_ntp_si_imagecredit_cutoff_fixes_android_1.37.x-linux/1/testReport. However, this is known and doesn't block uplift. DevOps fixing the above by restricting chromium tests to master as per https://github.com/brave/devops/pull/7195.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.37.x approved 👍 QA has verified the PR on Nightly as per #12711 (comment).

@kjozwiak kjozwiak merged commit 2e48a02 into 1.37.x Mar 28, 2022
@kjozwiak kjozwiak deleted the pr12711_ntp_si_imagecredit_cutoff_fixes_android_1.37.x branch March 28, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants