Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet mnemonic issue #21874

Closed
diracdeltas opened this issue Mar 25, 2022 · 3 comments · Fixed by brave/brave-core#12756
Closed

Wallet mnemonic issue #21874

diracdeltas opened this issue Mar 25, 2022 · 3 comments · Fixed by brave/brave-core#12756
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release/blocking release-notes/include security
Milestone
1.37.x - Release

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Mar 25, 2022 •
edited
Loading

see https://bravesoftware.slack.com/archives/C03907M5KB3/p1648184045529289 for details

QA repro steps: https://bravesoftware.slack.com/archives/C03907M5KB3/p1648217135541719?thread_ts=1648212664.335699&cid=C03907M5KB3
@diracdeltas diracdeltas added security priority/P1 A very extremely bad problem. We might push a hotfix for it. feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 25, 2022
@onyb onyb mentioned this issue Mar 25, 2022
Merged
25 tasks
@diracdeltas diracdeltas added release-notes/include QA/Yes QA/Test-Plan-Specified and removed OS/Android Fixes related to Android browser functionality labels Mar 25, 2022
This was referenced Mar 25, 2022
Closed
Closed
@kjozwiak kjozwiak added this to the 1.36.x - Release #7 milestone Mar 25, 2022
This was referenced Mar 25, 2022
Merged
Merged
@onyb onyb mentioned this issue Mar 26, 2022
Closed
7 tasks
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.37.107 Chromium: 100.0.4896.46 (Official Build) (64-bit)
-- | --
Revision | 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS | Windows 11 Version 21H2 (Build 22000.556)

Verification notes can be found via https://github.com/brave/internal/issues/863#issuecomment-1081429637.

@btlechowski
Copy link

Verification passed on

Brave 1.37.107 Chromium: 100.0.4896.46 (Official Build) (64-bit)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS Ubuntu 18.04 LTS

Verified in https://github.com/brave/internal/issues/863#issuecomment-1081882151

@stephendonner
Copy link

Verification PASSED using

Brave 1.37.107 Chromium: 100.0.4896.46 (Official Build) (x86_64)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS macOS Version 11.6.5 (Build 20G527)

Verified in https://github.com/brave/internal/issues/863#issuecomment-1082273072.

@kjozwiak kjozwiak mentioned this issue Mar 30, 2022
Closed
@rebron rebron changed the title wallet mnemonic issue Wallet mnemonic issue Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release/blocking release-notes/include security
Projects
None yet
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): prevent autocomplete for text input element brave/brave-core
4 participants
@stephendonner @diracdeltas @kjozwiak @btlechowski