Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Welcome tab needs a favicon #584

Closed
srirambv opened this issue Jul 18, 2018 · 2 comments · Fixed by brave/brave-core#543
Closed

Welcome tab needs a favicon #584

srirambv opened this issue Jul 18, 2018 · 2 comments · Fixed by brave/brave-core#543
Assignees
@cezaraugusto
Labels
about-pages/welcome QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Contributor

Actual result:

image
@srirambv srirambv added this to the Backlog milestone Jul 18, 2018
@rossmoody
Copy link
Contributor

rossmoody commented Jul 20, 2018 •
edited

@cezaraugusto has been supplied the goods here. this should popup in a future update.

cezaraugusto added a commit to brave/brave-core that referenced this issue Oct 2, 2018
@cezaraugusto
add welcome page favicon
bc22009 
closes brave/brave-browser#584
@cezaraugusto cezaraugusto mentioned this issue Oct 2, 2018
Merged
@bsclifton bsclifton changed the title Welcome tab needs a favcion Welcome tab needs a favicon Oct 2, 2018
bsclifton pushed a commit to bsclifton/brave-core that referenced this issue Oct 2, 2018
@cezaraugusto @bsclifton
add welcome page favicon
b95821e 
closes brave/brave-browser#584
@bsclifton bsclifton modified the milestones: 1.x Backlog, Releasable builds 0.55.x Oct 2, 2018
@srirambv
Copy link
Contributor Author

srirambv commented Oct 4, 2018 •
edited by btlechowski

Verification passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux

image

Verified passed with

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

screen shot 2018-10-08 at 3 49 54 pm

Verification passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows 7

image

@LaurenWags LaurenWags mentioned this issue Oct 8, 2018
Closed
@AlexeyBarabash AlexeyBarabash mentioned this issue Sep 8, 2021
Closed
@stephendonner stephendonner mentioned this issue Mar 18, 2022
Closed
33 tasks
@btlechowski btlechowski mentioned this issue Mar 18, 2022
Closed
33 tasks
@Uni-verse Uni-verse mentioned this issue Mar 21, 2022
Closed
1 task
This was referenced Mar 21, 2022
Closed
Closed
Closed
@Tonev Tonev mentioned this issue Mar 21, 2022
Open
@stephendonner stephendonner mentioned this issue Mar 21, 2022
Closed
This was referenced Mar 25, 2022
Closed
Closed
Closed
@btlechowski btlechowski mentioned this issue Mar 26, 2022
Closed
This was referenced Mar 27, 2022
Closed
Closed
Closed
Closed
Closed
@btlechowski btlechowski mentioned this issue Mar 28, 2022
Closed
@stephendonner stephendonner mentioned this issue Mar 28, 2022
Closed
@kaytwo kaytwo mentioned this issue Mar 28, 2022
Closed
@btlechowski btlechowski mentioned this issue Mar 28, 2022
Closed
This was referenced Mar 28, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 29, 2022
Closed
Closed
@Uni-verse Uni-verse mentioned this issue Mar 29, 2022
Closed
This was referenced Mar 29, 2022
Closed
Closed
This was referenced Mar 29, 2022
Closed
Closed
@stephendonner stephendonner mentioned this issue Mar 29, 2022
Closed
@Tonev Tonev mentioned this issue Mar 31, 2022
Open
@MadhaviSeelam MadhaviSeelam mentioned this issue Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
about-pages/welcome QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

add welcome page favicon brave/brave-core
7 participants
@cezaraugusto @bsclifton @bradleyrichter @srirambv @LaurenWags @rossmoody @btlechowski