HTTPSE upgrades not working with Chromium 101

[LaurenWags]

Description

HTTPSE upgrades are not working with 1.38.x w/ Chromium 101. They do work on 1.37.x with Chromium 100.

When using 1.38.x, doesn't matter if shields v2 are enabled or not.

Worked with 1.38.103 which had Chromium 100, does not work with Chromium 101 versions of 1.38.x.

Steps to Reproduce

1. Clean profile 1.38.105
2. Navigate to http://https-everywhere.badssl.com/

In general, we should ensure that HTTPS redirects are working as expected on new/older profiles. As per @mkarolin, we should also ensure that HTTPS redirects are working with profiles that have the following directory already created:

<PROFILE_DIR>/oofiananboodjbbmdelgdommihjbkfag/1.0.91/6.0/httpse.leveldb

Actual result:

not upgraded to https with 1.38.x with either shields v1 or v2

v1	v2

Expected result:

upgraded to https as in 1.37.x

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.38.105 Chromium: 101.0.4951.41 (Official Build) (x86_64)
Revision	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS	macOS Version 12.3.1 (Build 21E258)

Version/Channel Information:

• Can you reproduce this issue with the current release? 1.37.x no, 1.38.x yes
• Can you reproduce this issue with the beta channel? probably
• Can you reproduce this issue with the nightly channel? 1.40.x yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @mkarolin

[kjozwiak]

@LaurenWags hmmm so on Win 11 x64, I'm seeing the following:

• install and launch 1.37.116 Chromium: 100.0.4896.127
• load http://https-everywhere.badssl.com
• you'll notice the same result as above (re: not redirecting to the https page)
• refresh the same tab (same result as before re: not redirecting the page to https
• load http://https-everywhere.badssl.com in a new tab and you'll get redirected as expected

But it seems to be working on my end with 1.38.105 Chromium: 101.0.4951.41 using a new profile. Example:

Welcome.to.Brave.-.Brave.2022-04-22.09-52-31.mp4

[stephendonner]

I was able to reproduce this issue on the first try, new profile with 1.38.105 on macOS-x64, Monterey

Brave	1.38.105 Chromium: 101.0.4951.41 (Official Build) (x86_64)
Revision	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS	macOS Version 12.4 (Build 21F5058e)

http://https-everywhere.badssl.com	brave://components

[GeetaSarvadnya]

Reproduced with 1.38.105 CR101 but issue is not reproducible with 1.38.103 CR100 and 1.37.116

[kjozwiak]

The above will require 1.38.107 or higher for 1.38.x verification 👍

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.38.107 Chromium: 101.0.4951.41 (Official Build) (64-bit)
-- | --
Revision | 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS | Windows 10 Version 21H2 (Build 19044.1645)

Clean profile

• Confirmed that HTTPS upgrade works fine in 1.38.107 in a clean profile
  

Upgrade profile

• Confirmed that HTTPS upgrade works fine in an upgraded profile
  

• Confirmed that HTTPS upgrade works in a profile where ...User Data\oofiananboodjbbmdelgdommihjbkfag\1.0.91\6.0\httpse.leveldb is already created

Example	Example

[stephendonner]

Verified PASSED using

Brave	1.38.107 Chromium: 101.0.4951.41 (Official Build) (x86_64)
Revision	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS	macOS Version 11.6.5 (Build 20G527)

Clean profile

• Confirmed that HTTPS upgrade works fine in 1.38.107 in a clean profile

Upgrade profile

• Confirmed that HTTPS upgrade works fine in an upgraded profile

• Confirmed that HTTPS upgrade works in a profile where <userProfile> Data\oofiananboodjbbmdelgdommihjbkfag\1.0.91\6.0\httpse.leveldb is already created

Example	Example

[btlechowski]

Verification passed on

Brave	1.38.107 Chromium: 101.0.4951.41 (Official Build) (64-bit)
Revision	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS	Ubuntu 18.04 LTS

Clean profile

• Confirmed that HTTPS upgrade works fine in 1.38.107 in a clean profile

Upgrade profile

• Confirmed that HTTPS upgrade works fine in an upgraded profile

• Confirmed that HTTPS upgrade works in a profile where <userProfile> Data\oofiananboodjbbmdelgdommihjbkfag\1.0.91\6.0\httpse.leveldb is already created

Example	Example