-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update brave://settings/shields to support Shields v2 #21926
Comments
Above requires |
@brave/legacy_qa we should also confirm that setting global shield options propagates to sites where site specific shield options have not already been set as well as confirm global shield settings are retained after upgrade. |
Verification
and
Filed a bug #22382
|
Verification
NOTE: the feature itself isn't correctly working right now; tracked over in #22503. Tested and verified was the enabling/disabling, and propagation of the feature, due to the above.
|
Verification passed on
Verified global shield settings are reflected on pages without per page shield settings amp Tested in #22228 ads and trackers blocked https everywhere block script fingerprinting Fingerprinting strings are the same
Turned on
block cookies |
Description
Update brave://settings/shields to support Shields v2.
Update settings/text/drop down labels to match Shields v2.
Remove Default view section which no longer applies.
Reorder cookie and fingerprint blocking so that fingerprint blocking is before (or on top) of cookie blocking to match Shields v2.
Actual result:
Expected result:
Reproduces how often:
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: