Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-redirect AMP pages - Loops - page won't load. #22610

Closed
RonnyTNL opened this issue Apr 28, 2022 · 9 comments · Fixed by brave/brave-core#13213
Closed

Auto-redirect AMP pages - Loops - page won't load. #22610

RonnyTNL opened this issue Apr 28, 2022 · 9 comments · Fixed by brave/brave-core#13213

Comments

@RonnyTNL
Copy link

Description

Loading this ULR causes a AMP redirect loop, page won't load, DevTools network shows looping pageload /amp

Steps to Reproduce

  1. Open URL https://t.co/0Ydr4haUQd which should land at
  2. https://www.airlive.net/new-footage-shows-an-ukrainian-mig-29-taking-off-from-mykolaiv-seconds-before-the-runway-is-shelled-by-the-russians/
  3. Watch the Omnibox blink
  4. Devtools watch the Network tab and see that it loads page then /amp and loops on that

Actual result:

Page doesn't load (at all)

Expected result:

Page should load

Reproduces how often:

Easy 100%

Brave version (brave://version info)

Version 1.38.109 Chromium: 101.0.4951.41 (Official Build) (64-bit)

Version/Channel Information:

Not tested

  • Can you reproduce this issue with the current release?
  • Yes
  • Can you reproduce this issue with the beta channel?
  • Not Tested
  • Can you reproduce this issue with the nightly channel?
  • Not Tested

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    No
  • Does the issue resolve itself when disabling Brave Rewards?
    No enabled
  • Is the issue reproducible on the latest version of Chrome?
    No (because no AMP auto-redirect)

Miscellaneous Information:

All extensions disabled during testing so that cannot interfere.

@stephendonner
Copy link

Confirming using

Brave 1.39.84 Chromium: 101.0.4951.41 (Official Build) beta (x86_64)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS macOS Version 11.6.5 (Build 20G527)

cc @ShivanKaul

Screen Shot 2022-04-28 at 1 41 26 PM

@ShivanKaul
Copy link
Collaborator

@ShivanKaul ShivanKaul self-assigned this Apr 29, 2022
@ShivanKaul ShivanKaul added the OS/Android Fixes related to Android browser functionality label Apr 29, 2022
@ShivanKaul ShivanKaul added this to the 1.40.x - Nightly milestone Apr 29, 2022
@bridiver
Copy link
Contributor

bridiver commented May 6, 2022

this STR doesn't properly replicate the problem because we're not redirecting from an amp page to the canonical page

@rebron rebron added this to On Deck in General May 10, 2022
General automation moved this from On Deck to Completed May 10, 2022
@stephendonner
Copy link

Verified PASSED using

Brave 1.40.68 Chromium: 102.0.5005.50 (Official Build) beta (x86_64)
Revision f6e2cf8f59ec714bdcff8499991d55898875f287-refs/branch-heads/5005@{#648}
OS macOS Version 12.5 (Build 21G5027d)

Steps:

  1. installed 1.40.68
  2. launched Brave
  3. opened a new-tab page
  4. loaded https://t.co/0Ydr4haUQd (https://www.airlive.net/new-footage-shows-an-ukrainian-mig-29-taking-off-from-mykolaiv-seconds-before-the-runway-is-shelled-by-the-russians/)

Confirmed the page loaded without issue

Screen Shot 2022-05-24 at 3 09 11 PM

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.40.80 Chromium: 102.0.5005.78 (Official Build) beta (64-bit)
-- | --
Revision | df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS | Windows 11 Version 21H2 (Build 22000.675)

Steps:

Confirmed the page loaded without issue

image

@kjozwiak
Copy link
Member

kjozwiak commented Jun 3, 2022

Removed the QA Pass-Win64 & QA Pass-macOS labels as this was uplifted into 1.39.x via brave/brave-core#13582 and will need a quick recheck using 1.39.x just to make sure everything is still working on the 1.39.x branch.

@MadhaviSeelam
Copy link

Verified Passed using

Brave | 1.39.117 Chromium: 102.0.5005.78 (Official Build) (64-bit)
-- | --
Revision | df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS | Windows 11 Version 21H2 (Build 22000.675)

Steps:

  • installed 1.39.117
  • launched Brave
  • opened a new-tab page
  • loaded https://t.co/0Ydr4haUQd (https://www.airlive.net/new-footage-shows-an-ukrainian-mig-29-taking-off-from-mykolaiv-seconds-before-the-runway-is-shelled-by-the-russians/)
  • Confirmed the page loaded without issue

image

@stephendonner
Copy link

Verified PASSED using

Brave 1.39.117 Chromium: 102.0.5005.78 (Official Build) (x86_64)
Revision df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS macOS Version 11.6.6 (Build 20G624)

Steps:

  1. installed 1.39.117
  2. launched Brave
  3. opened a new-tab page
  4. loaded https://t.co/0Ydr4haUQd (https://www.airlive.net/new-footage-shows-an-ukrainian-mig-29-taking-off-from-mykolaiv-seconds-before-the-runway-is-shelled-by-the-russians/)

Confirmed the page loaded without issue

Screen Shot 2022-06-03 at 9 21 13 AM

@Uni-verse
Copy link
Contributor

Uni-verse commented Jun 7, 2022

Verification completed on Samsung Galaxy S21 running Android 12 using

Brave	1.39.118 Chromium: 102.0.5005.78 (Official Build) (64-bit) 
Revision	df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS	Android 12; Build/SP1A.210812.016

Page Re-direct loop on mobile, tablet.

amp03.mp4
amp02.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment