Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tab + shows the different background color when mouse is not hovered #23423

Closed
GeetaSarvadnya opened this issue Jun 13, 2022 · 5 comments · Fixed by brave/brave-core#13841

Comments

@GeetaSarvadnya
Copy link

Description

New tab + shows the different background color when mouse is not hovered

Steps to Reproduce

  1. NA

Actual result:

image

Expected result:

image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.41.58 Chromium: 103.0.5060.42 (Official Build) nightly (64-bit)
Revision de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS Windows 10 Version 21H2 (Build 19044.1706)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome?NA

Miscellaneous Information:

cc: @brave/qa-team @simonhong @mkarolin @emerick

@GeetaSarvadnya
Copy link
Author

As per the slack thread @bradleyrichter confirmed we should retain brave branded colors https://bravesoftware.slack.com/archives/C7VLGSR55/p1655131986081449?thread_ts=1654874758.988509&cid=C7VLGSR55

@emerick
Copy link
Contributor

emerick commented Jun 13, 2022

@simonhong simonhong self-assigned this Jun 13, 2022
@rebron rebron added this to In progress in General Jun 14, 2022
@GeetaSarvadnya
Copy link
Author

The issue needs to be fixed for the Search Tabs background color also. Reproduced in Linux - 1.40.103

image

simonhong added a commit to brave/brave-core that referenced this issue Jun 17, 2022
brave/brave-browser#23423

Introduced for color mixers for light/dark/private/tor window for using
our theme colors from color provider.

With this PR, brave's background color of new tab button/tab search button
is used.
simonhong added a commit to brave/brave-core that referenced this issue Jun 20, 2022
brave/brave-browser#23423

Introduced for color mixers for light/dark/private/tor window for using
our theme colors from color provider.

With this PR, brave's background color of new tab button/tab search button
is used.
simonhong added a commit to brave/brave-core that referenced this issue Jun 20, 2022
brave/brave-browser#23423

Introduced for color mixers for light/dark/private/tor window for using
our theme colors from color provider.

With this PR, brave's background color of new tab button/tab search button
is used.
simonhong added a commit to brave/brave-core that referenced this issue Jun 20, 2022
brave/brave-browser#23423

Introduced for color mixers for light/dark/private/tor window for using
our theme colors from color provider.

With this PR, brave's background color of new tab button/tab search button
is used.
General automation moved this from In progress to Completed Jun 20, 2022
@simonhong simonhong added this to the 1.42.x - Nightly milestone Jun 20, 2022
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jun 24, 2022

Verification PASSED on

Brave | 1.40.107 Chromium: 103.0.5060.53 (Official Build) (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 10 Version 21H2 (Build 19044.1766)

  • Verified the STR from the description

Light theme

1.40.105 Before the fix 1.40.107 After the fix
image image

Dark theme

1.40.105 Before the fix 1.40.107 After the fix
image image

PT and TOR tabs

1.40.105 Before the fix 1.40.107 After the fix
image image

Custom theme

1.40.105 Before the fix 1.40.107 After the fix
image image

@GeetaSarvadnya
Copy link
Author

Verified the comments #23423 (comment) and ensured the Search tabs bg color issue is also fixed in Linux 1.40.107

image

@rebron rebron removed this from Completed in General Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment