Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 102 to Chromium 103 #22804

Closed
emerick opened this issue May 12, 2022 · 3 comments · Fixed by brave/brave-core#13331
Closed

Upgrade from Chromium 102 to Chromium 103 #22804

emerick opened this issue May 12, 2022 · 3 comments · Fixed by brave/brave-core#13331

Comments

@emerick
Copy link
Contributor

emerick commented May 12, 2022

Upgrade from Chromium 102 to Chromium 103.

https://chromium.googlesource.com/chromium/src/+log/102.0.5005.50..103.0.5042.0/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop affected areas:

  • brave://settings - "Advanced" button removed from sidenav
  • Clear browser data on exit
  • Sync
  • Brave Wallet - Underlying Permissions API changed, affecting Brave Wallet functionality
  • Component updater

Android affected areas:

  • New tab page UI
  • Overview mode UI
  • Bottom toolbar UI
  • VPN (just double check that service generally works)
  • Bookmark/unbookmark pages
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 13, 2022

Verification PASSED on


Brave | 1.41.58 Chromium: 103.0.5060.42 (Official Build) nightly (64-bit)
-- | --
Revision | de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS | Windows 10 Version 21H2 (Build 19044.1706)

Case 1 : brave://settings/ - Additional settings dropdown removal
  • Confirmed Additional settings section dropdown in removed from brave://settings sidebar menu
  • Confirmed that the settings which are part of additional settings are added in the main Settings sidebar menu
  • Confirmed that clicking on each additional setting redirected to the intended page

image

Case 2: Clear browser data on exit
  • Confirmed clear data on exit clears/delete the Browser history
  • Confirmed that clear data on exit clear/delete the Cookies and other site data
  • Confirmed that clear data on exit clear/delete the Passwords and other sign-in data
  • Confirmed that clear data on exit clear/delete the Autofillform data
  • Confirmed that clear data on exit clear/delete the Site and shield settings
  • Confirmed that clear data on exit clear/delete the Passwords and other sign-in data
  • Confirmed that clear data on exit clear/delete the Download history
  • Confirmed that clear data on exit clear/delete the Cached images and files

image
`

Case 3: Sync
  • Confirmed 1.41.58 (nightly ) can be synced with the existing sync chain
  • Confirmed bookmarks, passwords, history, extensions, etc can be synced with nightly channel
  • Sync cannot be initiated on nightly channel with other channels, logged and encountered Unable to initiate the sync chain between nightly and other channels #23428
  • Nightly device is removed from the existing sync chain and the confirmed sync chain is reset on the nightly device
  • Confirmed that sync can be reset on nightly build via Leave sync chain button
Case 4: Component updater
  • Confirmed no new components are added as part of CR 103
  • Confirmed that components are up-to-date and version details are shown as expected
  • Confirmed that no components are displayed with error
    image

Settings comparison:

  • Confirmed no new settings are added as part of CR 103
  • Confirmed a new settings Show bookmarks button is added as part of Brave
    image
  • Confirmed Additional settings are merged with Settings sidebar menu and there is no additional settings section in the sidebar menu in brave://settings
  • Confirmed Language expand bubble is removed as part of CR103 and confirmed with @rebron and @aguscruiz that brave will retain this change
    image

Components updater:

  • Confirmed no new components are added as part of CR 103
1.41.59 - CR 103 1.39.22 - CR 102
image image

Startup calls:

  • Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
  • Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

Brave Wallet

  • Verified able to create a new wallet
  • Verified able to restore wallet from seed phrase
  • Verified able to connect Ledger/Trezor and import accounts
  • Verified able to perform a send transaction on software wallet
  • Verified able to perform a send transaction from imported Ledger accounts
  • Send transactions from imported Trezor failed. Logged #23448
  • Swap transactions on software wallet fails. Logged #23443
  • Verified able to create Solana accounts
  • Verified able to create Filecoin accounts with flags enabled
  • Verified able to add a custom token
  • Verified all pre-loaded EVM's can be hidden from brave://settings/wallet/networks
  • Verified all pre-loaded EVM's show the native tokens
  • Verified selecting the onramp providers load the correct page from Buy tab
  • Verified able to connect to Dapp's
  • Verified able to add a network and switch network
  • Verified able to sign messages
  • Verified able to encrypt/decrypt messages

@Uni-verse
Copy link
Contributor

Uni-verse commented Jun 14, 2022

Verification PASSED for Android ARM using v1.41.62 (Chromium 103.0.5060.42)

Devices Tested on:
Samsung Galaxy GS 21 5G | Android 12
Samsung Galaxy Tab S7 | Android 12

PASS - New tab page UI
PASS - Overview mode UI
PASS - Bottom toolbar UI
PASS - VPN (just double check that service generally works)
PASS - Bookmark/unbookmark pages

@Uni-verse Uni-verse added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass - Android ARM QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 14, 2022
@kjozwiak
Copy link
Member

Labelling as QA/No & release-notes/exclude in favour of #23482.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants