Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop push notifications do not always function (twitter, reddit, etc) #2362

Open
Brave-Matt opened this issue Dec 5, 2018 · 36 comments
Open

Comments

@Brave-Matt
Copy link
Collaborator

@Brave-Matt Brave-Matt commented Dec 5, 2018

Latest status: see #2362 (comment)

Description

I've seen DT notifications for various sites (gmail, community, twitter, reddit, etc) work without any issues or conflicts with settings. DT notifications for Youtube however do not work. Alert never actually get displayed in b-c (nor does it play the sound).

This was tested using Dev, Beta and Release builds. Windows 7/Windows 10.
Shields up/down and changing global shields have no effect.

Steps to Reproduce

  1. Visit YouTube, sign into YT account
  2. Verify that:
  • Notifications from YT are set to "Allowed", either by prompt on visit or manual entry (see #1775 ) in browser
  • Desktop notifications set to "on" in YT (Click the notification icon (bell) --> Gear icon --> Notification Settings --> Desktop Notifications). Note that it will display the Chrome icon instead of the Brave icon.
  • Notifications are enabled in Windows system settings
  1. Try and provoke a notification from you YT account. I tested this by sending both messages, and commenting on a video I put on my channel from a separate account.
  2. Adjust Shields settings (global and/or panel), and repeat

Actual result:

No notification is displayed on desktop. Notifications do appear on YT.

Expected result:

Desktop notification appears as intended, notifications appear on YT as well.

Reproduces how often:

Easily/always

Brave version (brave://version info)

Release: 0.56.15
Beta: 0.57.8
Dev: 0.58.10

Reproducible on current release:

Yes

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    No
  • Is the issue reproducible on the latest version of Chrome?
    No - notifications are displayed as intended. I was tricked by this more than once.

Additional Information

User(s) also reporting this on Community:
https://community.brave.com/t/version-0-56-7-chromium-70-0-3538-77-official-build-beta-64-bit-youtube-notifications-or-lack-of/36771/26

@Brave-Matt

This comment has been minimized.

@Brave-Matt

This comment has been minimized.

Copy link
Collaborator Author

@Brave-Matt Brave-Matt commented Mar 29, 2019

This seems to be true for Twitter as well -- Navigating to "Web notifiactions" in Twitter's settings displays the following message:
image
Note that I have seen the offer to enable web notifications on Twitter in previous releases.

@Brave-Matt

This comment has been minimized.

Copy link
Collaborator Author

@Brave-Matt Brave-Matt commented Apr 2, 2019

@Brave-Matt

This comment has been minimized.

@FelschR

This comment has been minimized.

Copy link

@FelschR FelschR commented Apr 9, 2019

I'm pretty sure the reason why it's not working is #2143
On Android it's still working atm because FCM wasn't disabled there.

I'm not entirely familiar with Chrome's history with FCM but I think they initially offered a custom FCM/GCM API (https://developers.chrome.com/extensions/gcm) and later added support for the Push API once it was standardised.
Maybe they've reused parts of the FCM implementation for the Push API. So #2143 probably removed too much.
I'm not even sure if there is still such a thing as an FCM API in Chrome or if they maybe just used that as an internal name for their Push API implementation. At least chrome.gcm is not available anymore.

Hopefully this contains some new insight.

@mrdavey

This comment has been minimized.

Copy link

@mrdavey mrdavey commented May 1, 2019

I'm having the same issue and suspect that @FelschR is correct that it is FCM related.
I'm testing web push notifications using Firebase FCM and it works perfectly on Chrome, Opera, and Firefox, but not Brave. (No Safari as it doesn't support Push API)

According to FCM documentation:

The FCM JavaScript API lets you receive notification messages in web apps running in browsers that support the Push API. This includes the browser versions listed in this support matrix.

It seems Brave's Push API is broken.

@Brave-Matt Brave-Matt changed the title Desktop notifications from Youtube do not function Desktop notifications do not always function May 6, 2019
@Brave-Matt

This comment has been minimized.

Copy link
Collaborator Author

@Brave-Matt Brave-Matt commented May 6, 2019

@bbondy

This comment has been minimized.

Copy link
Member

@bbondy bbondy commented May 6, 2019

@simonhong could you take a look?

@simonhong

This comment has been minimized.

Copy link
Collaborator

@simonhong simonhong commented May 10, 2019

On my local, I debugged with gmail and youtube service on MacOS.
With youtube, renderer process requests notification displaying via NotificationManager::DisplayPersistentNotification().
With gmail, NotificationManager::DisplayNonPersistentNotification() was used.
On Brave, I only can get gmail notification.
On Chromium, both notifications are displayed.
And according to notification spec and comments, persistent notification is a notification with an associated service worker registration.

I think persistent notification seem not working properly on Brave.
But not sure it is youtube specific problem or not. Needs more debugging.

Push notification doesn't work with Brave. - https://serviceworke.rs/push-simple_demo.html

@simonhong

This comment has been minimized.

Copy link
Collaborator

@simonhong simonhong commented May 13, 2019

After re-enabling GCM client (we disabled by #1716), I got notification from youtube and demo of https://serviceworke.rs/push-simple_demo.html works well.

However, still web notification of twitter can't be enabled. (Same as chromium)

@Brave-Matt

This comment has been minimized.

Copy link
Collaborator Author

@Brave-Matt Brave-Matt commented May 14, 2019

+1 https://community.brave.com/t/notification-enabled-but-not-working/49594/53?u=mattches

Note that 9 new users have joined the above thread confirming that they're unable to receive notifications.

@WorldLanguages

This comment has been minimized.

Copy link

@WorldLanguages WorldLanguages commented Jun 24, 2019

After re-enabling GCM client (we disabled by #1716), I got notification from youtube and demo of https://serviceworke.rs/push-simple_demo.html works well.

However, still web notification of twitter can't be enabled. (Same as chromium)

@simonhong This isn't working in latest Brave Stable, even with shields off: https://serviceworke.rs/push-simple_demo.html

@snowbound

This comment has been minimized.

Copy link

@snowbound snowbound commented Jun 24, 2019

I went back to using Firefox rather than continue to use Chrome and put up with Google antics. On the Chromium side both Brave and MS Edge Chromium beta and dev have the notification issues

@simonhong

This comment has been minimized.

Copy link
Collaborator

@simonhong simonhong commented Jun 26, 2019

@WorldLanguages This issue is blocked by #4431

@jamesray1

This comment has been minimized.

Copy link

@jamesray1 jamesray1 commented Aug 6, 2019

Looking forward to this being fixed after or with #4431. In the mean time I'll go back to using Firefox. Gmail notifications don't work for me despite allowing notifications:

image

@snowbound

This comment has been minimized.

Copy link

@snowbound snowbound commented Aug 6, 2019

Sad to say that over this past weekend I uninstalled Brave Beta as well as both of MS Chromium-based browsers which all suffer from this issue.

@FelschR

This comment has been minimized.

Copy link

@FelschR FelschR commented Aug 6, 2019

I, too, have reverted to Chrome/Chromium on my devices due to this issue.

Additionally I was also missing the Android app's lack of creating WebAPKs (https://github.com/brave/browser-android-tabs/issues/645) quite a bit.

@bsclifton

This comment has been minimized.

Copy link
Member

@bsclifton bsclifton commented Aug 6, 2019

We are looking at a fix for this 😄 Stay tuned...

@sakralbar

This comment has been minimized.

Copy link

@sakralbar sakralbar commented Aug 17, 2019

No push notifications with last version of Brave both Linux and Android platform.

@bsclifton

This comment has been minimized.

Copy link
Member

@bsclifton bsclifton commented Aug 19, 2019

@jumde is assigned to #2301 which (when fixed) should also fix this

We've got to look at a few things:

  • does using the service use a Google API key? some services (translations, speech api) require the caller provide an API key which has rate limits. Some limits are low and increasing them means we would need to evaluate the cost
    • if the service does use a Google API key, we may need to look at the Mozilla implementation for this
    • if the service does not use a Google API key, we should be able to put this option behind a config flag in settings and then setup a proxy for calling

We should see progress on this in the next few weeks. There may be more updates in #2301 for folks wanting to subscribe to the issue

@Brave-Matt

This comment has been minimized.

Copy link
Collaborator Author

@Brave-Matt Brave-Matt commented Aug 21, 2019

@Adrymate9

This comment has been minimized.

Copy link

@Adrymate9 Adrymate9 commented Sep 3, 2019

Contribution in the community. On a phone with Android 7 where notifications work correctly. However on my phone with Android 8 unfortunately not.

https://community.brave.com/t/notification-enabled-but-not-working/49594/95?u=adrymate9

@bsclifton bsclifton removed the blocked label Sep 3, 2019
@bsclifton

This comment has been minimized.

Copy link
Member

@bsclifton bsclifton commented Sep 3, 2019

Removing blocked label as @jumde has done some pathfinding and we should be able to enable this without issues 😄

Our current status (as far as I know):

  • We'll need to proxy the requests. This work has already been started
  • We may need to add a whitelist exception for this in brave-browser
  • A setting will need to be created (similar to Chromecast), defaulted to off
@jumde

This comment has been minimized.

Copy link
Contributor

@jumde jumde commented Sep 4, 2019

Thanks for highlighting the current progress @bsclifton. Proxies are set-up and the work for an off-by-default setting is in place. The PR will be ready for review by the end of this week.

This work will be followed by: #4431 as a complete solution for push notifications cc: @rebron

@Adrymate9

This comment has been minimized.

Copy link

@Adrymate9 Adrymate9 commented Sep 4, 2019

Will this solution also be implemented in the Brave version for Android?

@aboydpoi

This comment has been minimized.

Copy link

@aboydpoi aboydpoi commented Sep 26, 2019

Is there any fix?

@Adrymate9

This comment has been minimized.

Copy link

@Adrymate9 Adrymate9 commented Sep 26, 2019

@aboydpoi For me, it still doesn't work. Right now I use Brave version 1.4.0 rc3 on my phone.

@jumde

This comment has been minimized.

Copy link
Contributor

@jumde jumde commented Oct 4, 2019

Fix for issue #2301 enables Push notifications in Brave, but push notifications on some sites including Youtube, Twitter might not work because of an upstream issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1011244 - we are working with the chromium team to fix this. We are using this issue to track the upstream fix. Stay tuned.

@szaimen

This comment has been minimized.

Copy link

@szaimen szaimen commented Oct 9, 2019

Will this solution also be implemented in the Brave version for Android

I am also wondering🤔

@dijonkitchen

This comment has been minimized.

Copy link

@dijonkitchen dijonkitchen commented Nov 25, 2019

Note that this doesn't work for Outlook's (https://outlook.office365.com:443 or https://outlook.office.com:443) desktop notifications either.

Works on Chrome when desktop notifications are enabled in the Outlook settings.

@BabyJesus666

This comment has been minimized.

Copy link

@BabyJesus666 BabyJesus666 commented Dec 15, 2019

Not sure how valuable this feedback is but they aren't working with Dlive.tv either

@Brave-Matt

This comment has been minimized.

Copy link
Collaborator Author

@Brave-Matt Brave-Matt commented Dec 16, 2019

+1 from Community:
https://community.brave.com/t/gmail-notifications-dont-show-up-in-windows-10-action-center/90703/15
@jumde -- what is the status of this particular issue? It looks like it hasn't seen a much movement for some time now.

@PixelHir

This comment has been minimized.

Copy link

@PixelHir PixelHir commented Dec 20, 2019

Any updates, please?

@Brave-Matt

This comment has been minimized.

@bsclifton

This comment has been minimized.

Copy link
Member

@bsclifton bsclifton commented Jan 7, 2020

I believe the blocker for this is https://bugs.chromium.org/p/chromium/issues/detail?id=1011244 which is assigned to an owner that is OOO until Jan 13

Will mark issue as waiting-upstream

For folks that aren't aware, there is a Use Google Services for Push Messaging option under brave://settings/privacy (set to OFF by default) which, when enabled, may resolve items which are trying to use GCM
Screen Shot 2020-01-07 at 2 13 12 PM

@bsclifton bsclifton changed the title Desktop notifications do not always function Desktop notifications do not always function (twitter, reddit, etc) Jan 7, 2020
@bsclifton bsclifton changed the title Desktop notifications do not always function (twitter, reddit, etc) Desktop push notifications do not always function (twitter, reddit, etc) Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.