-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push notifications broken in brave-core #2301
Comments
@srirambv can you investigate maybe with a different HTML 5 push notification test suite? Need more info on this one. |
May also be related to #2362 |
Looks like the issue I mentioned in the following comment over here is related to this: |
Any news ? When we see the update witch will fix that notification problem? |
I'm also seeing that after allowing notifications, and maybe a refresh or something, the site settings says notifications are enabled but |
Ya, this bug is very annoying. I hope they will fix it soon. I was struggling to enable Facebook notifications and now I understand why it was unsuccessful. |
The main reason why I went back to Chrome after trying Brave for a month back in Nov/Dec last year and now MS has entered the chromium fray |
@rebron , any info about that bug? |
@rebron I would also like to confirm that these notifications are faulty. For example site: d2jsp.org wont register push notifications with brave, but does it on chrome. |
+1 |
@rebron Any update on this? I love the idea of this browser but broken Facebook and Twitter notifications are kind of a deal breaker. |
Yup with me its YouTube notifications have to work. The reason why I was one of the people who reported this issue back in Dec 2018. Using Firefox right now on Win10. |
@rebron Can I humbly request that this have a due date set prior to Google's Declarative Web Request/Manifest v3 enabling (I believe this is expected in October)? I imagine that there will be many people looking to switch around that time (when ad blockers like uBlock Origin will no longer work, at least in their current form), and so the easier the transition for them, the more likely they'll be to choose Brave over something like Firefox or Opera. |
Finally |
Fix for this issue enables Push notifications in Brave, but push notifications on some sites including Youtube, Twitter might not work because of an upstream issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1011244 - we are working with the chromium team to fix this. We are using issue #2362 to track the fix. Stay tuned! |
|
Verified passed with
Verification passed on
Verification passed on
|
Sorry but in Windows10 1909 I am still not seeing notifications in the browser
nor in Windows Action Center from YouTube when a subscribed channel goes
live. I have notications enabled for Brave in Windows10 just like I do for
Chrome and Firefox which both work wrt Windows 10 Action Center. I am
currently using Version 1.1.5 Chromium: 78.0.3904.97 (Official Build) beta
(64-bit). <https://brave.com/latest/>
…On Wed, Nov 20, 2019 at 12:53 PM Lauren ***@***.***> wrote:
Verified passed with
Brave 1.1.5 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{
#859 <#859>}
OS macOS Version 10.13.6 (Build 17G5019)
- Verified test plan from brave/brave-core#3390
<brave/brave-core#3390> using second site
listed in the PR (first site listed was taken down).
- Verified on clean and upgrade profiles.
[image: Screen Shot 2019-11-20 at 1 43 20 PM]
<https://user-images.githubusercontent.com/28145373/69268312-dedc3a80-0b9c-11ea-876f-9890d3a84aea.png>
[image: Screen Shot 2019-11-20 at 1 43 27 PM]
<https://user-images.githubusercontent.com/28145373/69268322-e6034880-0b9c-11ea-9e20-8d30885085cf.png>
[image: PR3390-clean profile]
<https://user-images.githubusercontent.com/28145373/69268442-24006c80-0b9d-11ea-90d1-7ad9f130adde.png>
- Encountered #2301 (comment)
<#2301 (comment)>
/ #7031 <#7031>.
Intermittent push notification failures observed during testing with site
from PR, however per discussion with @jumde <https://github.com/jumde>
this could be due to rate limiting to avoid bots.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2301?email_source=notifications&email_token=AAERRMYUPEXXSOYJEFHBZ3LQUWBTRA5CNFSM4GHK6APKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEETZJJQ#issuecomment-556242086>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAERRM42SDSZMDPNKHMOTFLQUWBTRANCNFSM4GHK6APA>
.
|
OMG it looks like we're broken again in 1.1.11!! I'll revert ASAP and re-test, but just tested with several sites that worked OK last week. None work now. Update: There is a problem, but it turns out to not be in the push notification functionality per se. I am now on a different machine, and I noticed that the "Use Google Services for Push Notifications" was turned off somehow. I turned it on, and a "RELAUNCH" button comes up next to the setting. I hit it, machine relaunched, but notifications still didn't work. Then I sent the message above. Slackware 14.2-current (recent install) After banging my head on the wall and reverting all the way back to 1.1.1, which I knew worked OK, it still didn't work!! Went to settings, and I see the "Use Google" is still turned off!! I turned it on, relaunched, looked at settings it it still wan't on. So I turned it on, manually exited via the menu, and now all is well. . . . . |
I noticed that the "Use Google Services for Push Notifications" is turned off by default on Brave (Version 1.1.20 Chromium: 79.0.3945.74 (Official Build) (64-bit)). Is it mandatory to enable it for Push Notifications or there is any other way to send Push Notifications without enabling this setting? "Ooops a Problem Occurred |
@neerajsrivastava it's required to enable that setting (as far as I know), as there is a service call being made to GCM / FCM |
Where is the option to enable google services ? I can't see any option in chrome://settings/privacy Thanks |
"Use Google Services for Push Messaging" in Windows Version 1.1.23 Chromium: 79.0.3945.88 (Official Build) (64-bit) |
@totomaze you're several versions behind. Can you please update? (current version is @nexxai I believe we fixed that bug, but the fix may not be live yet (cc: @jumde). Instead of clicking the relaunch helper button, can you try just closing Brave manually? |
@nexxai @bsclifton - Yes this issue is fixed, but is not yet part of the stable release - brave/brave-core#4042 |
Hello I have Google push notifcations enabled AND I have Notifcations settings set to allow sites to ask. Only popular sites like Facebook and Trading View are successfully asking for notifications when I visit them, then their push notifications actually send. But news sites like Bitcoinist.com and Youtube are not asking. Does anyone know how to enable website push notifications? I’ve already gone to settings and selected, Allow Sites to ask for permission, but my crypto news sites won’t ask for permission to send notifications. I'm using Windows 10 -Brave is up to date: Version 1.5.113 Chromium: 80.0.3987.149 (Official Build) (64-bit) - just updated today. But I cannot receive notifications from sites like Youtube, Twitter, or Crypto news sites. I've seen many different threads on this topic but none have solved my issue. I've also been able to receive notifications from testing sites listed, but still no improvement. Help?? |
Description
HTML5 push notifications, which were previously working, no longer function in the brave-core milieu.
Test Plan
Specified here: brave/brave-core#3390
Steps to Reproduce
Actual result:
Popup posts, and site is registered with browser as "allowed" to send notifications. But nothing happens when the "Request sending . . . " button is pushed.
Expected result:
Browser should respond with a notification popup
Reproduces how often:
Always.
Brave version (brave://version info)
0.57.8
Reproducible on current release:
Yes.
Website problems only:
No.
Works just fine in latest version of Chrome Beta.
Additional Information
Subscription object is never sent to backend for processing, as verified with two sites I control which both are able to successfully send push notifications to instances of Chrome.
The text was updated successfully, but these errors were encountered: