-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong cookies state in Brave shields after adding URL in brave://settings/cookies
#24321
Comments
Yep, there is a bug in brave_shields_util.cc, should show 'block 3p' as it actually acts. |
@rebron |
The bug here is actually that shields reflects settings adding in |
@petemill re ^^ we could potentially show some kind of "warning" icon next to the shield settings if there are other settings that apply to the site in |
we probably can ask @rebron about potential UX updates |
@btlechowski just to be clear this reverts an earlier incorrect change that showed the effective cookie setting instead of the brave shields cookie setting. The dropdown is now back to what it has always been before that and we should address what we want to do about the combination of chromium and brave cookie settings (either the warning icon or disable the ability to add chromium cookie settings) cc @pes10k |
Verification
Case 1: Select cookies setting in
|
step 4 | step 6 | step 8 | step 10 |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Case 2: Select shields cookie setting in the Shields panel - Block all cookies
- PASSED
- continue from Case 1:
brave://settings/cookies
showsAllow all cookies
brave://settings/shields
showsDisabled
- Shields panel on
whatismybrowser.com
showsAllow all cookies
- return to
whatismybrowser.com
site - select
Block all cookies
in the Shields panel - refresh the page
- confirmed
Block all cookies
selection is retained - visit brave://settings/cookies
- verified previous selection (Case 1)
Allow all cookies
is retained - open
brave://settings/shields
- verified previous selection (Case 1)
Disabled
is retained - verified
www.whatismybrowser.com
is shown inSites that can never use cookies
step 1 | step 5 | step 7 | step 9 | step 10 |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Verification
|
Brave | 1.48.129 Chromium: 109.0.5414.87 (Official Build) beta (x86_64) |
---|---|
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241} |
OS | macOS Version 11.7.2 (Build 20G1020) |
Case 1: Select cookies setting in brave://settings/cookies
- Allow all cookies
- PASSED
- installed
1.48.129
- launched Brave
- visited www.whatismybrowser.com in a new-tab
- confirmed default settings for cookies
Block cross-site cookies
displayed as expected - opened
brave://settings/cookies
in a new tab - selected
Allow all cookies
- returned to www.whatismybrowser.com site
- confirmed
Allow all cookies
displayed in the Shields panel - opened
brave://settings/shields
- confirmed
Disabled
selection displayed forBlock cookies
option as expected
step 4 | step 6 | step 8 | step 10 |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Case 2: Select Shields cookie setting in the Shields panel - Block all cookies
- PASSED
- continued from Case 1:
brave://settings/cookies
showsAllow all cookies
brave://settings/shields
showsDisabled
- Shields panel on
whatismybrowser.com
showsAllow all cookies
- returned to
whatismybrowser.com
site - selected
Block all cookies
in the Shields panel - refreshed the page
- confirmed
Block all cookies
selection is retained - visited
brave://settings/cookies
- verified previous selection (Case 1)
Allow all cookies
is retained - opened
brave://settings/shields
- verified previous selection (Case 1)
Disabled
is retained - opened
brave://settings/cookies
- verified
www.whatismybrowser.com
is shown inSites that can never use cookies
step 1 | step 5 | step 7 | step 9 | step 10 |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Verification
Case 1: Select cookies setting in
|
step 4 | step 6 | step 8 | step 10 |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Case 2: Select shields cookie setting in the Shields panel - Block all cookies
- PASSED
- continue from Case 1:
brave://settings/cookies
showsAllow all cookies
brave://settings/shields
showsDisabled
- Shields panel on
whatismybrowser.com
showsAllow all cookies
- return to
whatismybrowser.com
site - select
Block all cookies
in the Shields panel - refresh the page
- confirmed
Block all cookies
selection is retained - visit brave://settings/cookies
- verified previous selection (Case 1)
Allow all cookies
is retained - open
brave://settings/shields
- verified previous selection (Case 1)
Disabled
is retained - verified
www.whatismybrowser.com
is shown inSites that can never use cookies
step 1 | step 5 | step 7 | step 9 | step 10 |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Follow up to #8604
After adding URL in
brave://settings/cookies
, the state in Brave Shields does not reflect actual stateSteps to Reproduce
brave://settings/cookies
www.whatismybrowser.com
inSites than can always use cookies
(do not checkIncluding third-party cookies on this site
)Actual result:
Brave Shields shows:
![image](https://user-images.githubusercontent.com/34715963/181626384-5bb5eb55-5280-4f8c-a9e3-d7dabe1050d7.png)
Allow all cookies
But behaves differently (blocks 3rd party cookies)
Expected result:
Brave Shields shows: ??
Definitely not
Allow all cookies
as the definitions are differentReproduces how often:
Easily reproduced
Brave version (brave://version info)
cc @rebron @boocmp @MadhaviSeelam @LaurenWags
The text was updated successfully, but these errors were encountered: