Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Rewards opt-in ("Start using Brave Rewards") should go through Rewards panel #24538

Closed
1 of 3 tasks
Miyayes opened this issue Aug 9, 2022 · 4 comments · Fixed by brave/brave-core#14858, brave/brave-core#14954 or brave/brave-core#14955
Assignees

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Aug 9, 2022

Description

Currently, the user can press "Start using Brave Rewards" in:

  1. The brave://rewards settings page
  2. The tipping banner

And go through a Rewards onboarding flow that takes place in those contexts.

Instead of doing that, we should funnel all "Start using Brave Rewards" to the Rewards panel by popping it open.

Solution

  • brave://rewards settings page Rewards opt-in --> Rewards panel
  • Tipping banner Rewards opt-in --> Rewards panel
  • Remove all in-page Rewards panel elements from brave://rewards while user is still not opted in, and center the Rewards opt-in component (edit: I think this was resolved for free with another issue, such as Update Rewards settings page to make responsive #16619? cc: @zenparsing)
@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 9, 2022
@Miyayes
Copy link
Collaborator Author

Miyayes commented Aug 9, 2022

Should be completed before/in conjunction with #24542.

@Miyayes Miyayes added QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. labels Aug 9, 2022
@Miyayes
Copy link
Collaborator Author

Miyayes commented Aug 10, 2022

For Android, make sure it opens the natively implemented Android Rewards panel.

@Miyayes Miyayes added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Aug 10, 2022
@Miyayes Miyayes removed the OS/Android Fixes related to Android browser functionality label Sep 1, 2022
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Sep 1, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 28, 2022

Verification is inprogress

Brave | 1.45.75 Chromium: 106.0.5249.65 (Official Build) beta (64-bit)
-- | --
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS | Windows 10 Version 21H2 (Build 19044.2006)

brave://rewards->Click on Start Using Rewards button
rewards

NTP->Click on Start Using Rewards button
rewards1

  • Installed 1.44.x and upgraded the profile to 1.45 (by renaming the profile folder to beta) and opened brave://rewards and clicked on Start using Brave Rewards button and ensured that the Rewards panel is opened with onboarding displayed

@LaurenWags
Copy link
Member

LaurenWags commented Oct 5, 2022

Verified with

Brave | 1.45.87 Chromium: 106.0.5249.91 (Official Build) beta (x86_64)
-- | --
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | macOS Version 12.6 (Build 21G115)

Verified test plan from brave/brave-core#14858 (comment).

  • Confirmed when on brave://rewards (prior to opting into Rewards), when the "Start using Brave Rewards" button is clicked, the panel opens and presents the option to join rewards.
  • Confirmed you are not opt-ed in until you select "Start using Brave Rewards" from the panel.
  • Confirmed once you select "Start using Brave Rewards" from the panel, Rewards page content is displayed.
Example Example Example
1 2 3

Additionally, spot checked other areas to ensure that the panel is opened for enabling Rewards/onboarding:

  • NTP Widget
  • NTP SI logo popup
  • brave://settings/rewards
  • Customize Dashboard settings
  • Twitter in-line tip button
  • GitHub in-line tip button
  • Reddit in-line tip button
Example Example Example Example Example Example Example
1 2 3 4 5 6 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment