clicking on an in-line tip icon does not open the panel to show rewards onboarding

[LaurenWags]

Description

Found while testing #14277

Prior to opting into Brave Rewards, if you click on an in-line tip icon (on twitter, reddit, gh), the panel should open and show onboarding. This is not occurring with 1.46.x. When you click on the in-line tip button nothing happens in the UI, so the button appears broken.

Not sure if this is related to the changes from #14277.

Note, confirmed that the panel opens as expected to offer onboarding with 1.45.x via #24538 (comment).

Steps to Reproduce

1. Fresh profile, relaunch to pull griffin seed
2. Go to twitter.com/emerick (or reddit.com/u/cryptojennie or open this GH issue)
3. Click on an in-line tip button

Note to @brave/qa-team - when retesting this issue after it's fixed, Case 4 from #14277 (comment) needs to be checked.

Actual result:

Nothing happens

Expected result:

Rewards panel opens to show onboarding

Reproduces how often:

easily

Brave version (brave://version info)

Brave | 1.46.66 Chromium: 107.0.5304.36 (Official Build) nightly (x86_64)
-- | --
Revision | 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS | macOS Version 12.6 (Build 21G115)

Version/Channel Information:

• Can you reproduce this issue with the current release? 1.44.x n/a
• Can you reproduce this issue with the beta channel? 1.45.x no
• Can you reproduce this issue with the nightly channel? 1.46.x yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @Miyayes @mkarolin

[LaurenWags]

Added release/blocking per discussion with @Miyayes

[LaurenWags]

Uplift required, adding QA/Blocked for now.

[kjozwiak]

Removing QA/Blocked. The above requires 1.46.80 or higher for 1.46.x verification 👍

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
-- | --
Revision | a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS | Windows 10 Version 21H2 (Build 19044.2130)

• Verified the STR from the description clicking on an in-line tip icon does not open the panel to show rewards onboarding #26109 (comment)

Twitter, Reddit and GH - PASSED

1. Fresh profile, relaunch to pull griffin seed
2. Go to twitter.com/emerick and reddit.com/u/cryptojennie and open this GH issue
3. Click on an in-line tip button somewhere on the page
4. Confirmed panel opened to show onboarding for Twitter, Reddit and GH

Twitter	Reddit	GH

Verified Case 4 from #14277 (comment) for the in-line tip buttons:

Case 4 - In-line tip button - PASSED

1. Fresh profile, relaunch to pull griffin seed
2. Go to twitter.com/emerick
3. Click on an in-line tip button
4. Panel is displayed, but do not opt in to rewards. Close panel.
5. Check for calls to *.rewards.brave.com
6. Confirm no calls to *.rewards.brave.com
7. Go to github.com/miyayes
8. Click on an in-line tip button
9. Panel is displayed, but do not opt in to rewards. Close panel.
10. Check for calls to *.rewards.brave.com
11. Confirm no calls to *.rewards.brave.com
12. Go to reddit.com/u/cryptojennie
13. Click on an in-line tip button
14. Panel is displayed, but do not opt in to rewards. Close panel.
15. Check for calls to *.rewards.brave.com
16. Confirm no calls to *.rewards.brave.com
17. Open NTP
18. Check for calls to *.rewards.brave.com
19. Confirm no calls to *.rewards.brave.com
20. Open browser Task Manager and confirm Ledger service is not running

Step 6	Step 11	Step 16	Step 19	Step 20